Skip to content

Commit e30e146

Browse files
fix: allow offline-only BatchFeatureView to skip online validation in get_historical_features
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
1 parent 09c470e commit e30e146

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1053,9 +1053,10 @@ def _get_feature_views_to_materialize(
10531053
f"Enable it before materializing."
10541054
)
10551055
if hasattr(feature_view, "online") and not feature_view.online:
1056-
raise ValueError(
1057-
f"FeatureView {feature_view.name} is not configured to be served online."
1058-
)
1056+
if not getattr(feature_view, "offline", False):
1057+
raise ValueError(
1058+
f"FeatureView {feature_view.name} is not configured to be served online."
1059+
)
10591060
elif (
10601061
hasattr(feature_view, "write_to_online_store")
10611062
and not feature_view.write_to_online_store

0 commit comments

Comments
 (0)