feast-dev
diff --git a/‎Makefile‎
Lines changed: 3 additions & 0 deletions b/‎Makefile‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎go/feast/basefeatureview.go‎
Lines changed: 11 additions & 6 deletions b/‎go/feast/basefeatureview.go‎
Lines changed: 11 additions & 6 deletions
diff --git a/‎go/feast/connector.go‎
Lines changed: 0 additions & 1 deletion b/‎go/feast/connector.go‎
Lines changed: 0 additions & 1 deletion
diff --git a/‎go/feast/feature.go‎
Lines changed: 17 additions & 0 deletions b/‎go/feast/feature.go‎
Lines changed: 17 additions & 0 deletions
@@ -78,6 +78,9 @@ test-python-universal-local:
 test-python-universal:
 	FEAST_USAGE=False IS_TEST=True python -m pytest -n 8 --integration --universal sdk/python/tests
 
+test-python-universal-go-server:
+	FEAST_USAGE=False IS_TEST=True python -m pytest -n 8 --integration --universal --noodfv sdk/python/tests
+
 format-python:
 	# Sort
 	cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/
 
@@ -8,12 +8,17 @@ import (
 
 type BaseFeatureView struct {
 	name string
-	features []*core.FeatureSpecV2
+	features []*Feature
 	projection *FeatureViewProjection
 }
 
-func NewBaseFeatureView(name string, features []*core.FeatureSpecV2) *BaseFeatureView {
-	base := &BaseFeatureView{name: name, features: features}
+func NewBaseFeatureView(name string, featureProtos []*core.FeatureSpecV2) *BaseFeatureView {
+	base := &BaseFeatureView{name: name}
+	features := make([]*Feature, len(featureProtos))
+	for index, featureSpecV2 := range featureProtos {
+		features[index] = NewFeatureFromProto(featureSpecV2)
+	}
+	base.features = features
 	base.projection = NewFeatureViewProjectionFromDefinition(base)
 	return base
 }
@@ -26,12 +31,12 @@ func (fv *BaseFeatureView) withProjection(projection *FeatureViewProjection) (*B
 	}
 	features := make(map[string]bool)
 	for _, feature := range fv.features {
-		features[feature.Name] = true
+		features[feature.name] = true
 	}
 	for _, feature := range projection.features {
-		if _, ok := features[feature.Name]; !ok {
+		if _, ok := features[feature.name]; !ok {
 			return nil, errors.New(fmt.Sprintf("The projection for %s cannot be applied because it contains %s which the " +
-												"FeatureView doesn't have.", projection.name, feature.Name))
+												"FeatureView doesn't have.", projection.name, feature.name))
 		}
 	}
 	return &BaseFeatureView{name: fv.name, features: fv.features, projection: projection}, nil
 
@@ -10,7 +10,6 @@ import (
 )
 
 func getOnlineStore(config *RepoConfig) (OnlineStore, error) {
-	fmt.Println(config == nil)
 	onlineStoreType, ok := getOnlineStoreType(config.OnlineStore)
 	if !ok {
 		return nil, errors.New(fmt.Sprintf("could not get online store type from online store config: %+v", config.OnlineStore))
 
@@ -0,0 +1,17 @@
+package feast
+
+import (
+	"github.com/feast-dev/feast/go/protos/feast/types"
+	"github.com/feast-dev/feast/go/protos/feast/core"
+)
+
+type Feature struct {
+	name string
+	dtype types.ValueType_Enum
+}
+
+func NewFeatureFromProto(proto *core.FeatureSpecV2) *Feature {
+	return &Feature	{ 	name: 	proto.Name,
+						dtype:	proto.ValueType,
+					}
+}
Original file line number	Diff line number	Diff line change
`@@ -8,12 +8,17 @@ import (`
`8`	`8`
`9`	`9`	`type BaseFeatureView struct {`
`10`	`10`	`name string`
`11`		`- features []*core.FeatureSpecV2`
	`11`	`+ features []*Feature`
`12`	`12`	`projection *FeatureViewProjection`
`13`	`13`	`}`
`14`	`14`
`15`		`-func NewBaseFeatureView(name string, features []core.FeatureSpecV2) BaseFeatureView {`
`16`		`- base := &BaseFeatureView{name: name, features: features}`
	`15`	`+func NewBaseFeatureView(name string, featureProtos []core.FeatureSpecV2) BaseFeatureView {`
	`16`	`+ base := &BaseFeatureView{name: name}`
	`17`	`+ features := make([]*Feature, len(featureProtos))`
	`18`	`+ for index, featureSpecV2 := range featureProtos {`
	`19`	`+ features[index] = NewFeatureFromProto(featureSpecV2)`
	`20`	`+ }`
	`21`	`+ base.features = features`
`17`	`22`	`base.projection = NewFeatureViewProjectionFromDefinition(base)`
`18`	`23`	`return base`
`19`	`24`	`}`
`@@ -26,12 +31,12 @@ func (fv BaseFeatureView) withProjection(projection FeatureViewProjection) (*B`
`26`	`31`	`}`
`27`	`32`	`features := make(map[string]bool)`
`28`	`33`	`for _, feature := range fv.features {`
`29`		`- features[feature.Name] = true`
	`34`	`+ features[feature.name] = true`
`30`	`35`	`}`
`31`	`36`	`for _, feature := range projection.features {`
`32`		`- if _, ok := features[feature.Name]; !ok {`
	`37`	`+ if _, ok := features[feature.name]; !ok {`
`33`	`38`	`return nil, errors.New(fmt.Sprintf("The projection for %s cannot be applied because it contains %s which the " +`
`34`		`- "FeatureView doesn't have.", projection.name, feature.Name))`
	`39`	`+ "FeatureView doesn't have.", projection.name, feature.name))`
`35`	`40`	`}`
`36`	`41`	`}`
`37`	`42`	`return &BaseFeatureView{name: fv.name, features: fv.features, projection: projection}, nil`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ import (`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`func getOnlineStore(config *RepoConfig) (OnlineStore, error) {`
`13`		`- fmt.Println(config == nil)`
`14`	`13`	`onlineStoreType, ok := getOnlineStoreType(config.OnlineStore)`
`15`	`14`	`if !ok {`
`16`	`15`	`return nil, errors.New(fmt.Sprintf("could not get online store type from online store config: %+v", config.OnlineStore))`