Skip to content

Commit dff75e0

Browse files
authored
Merge pull request #29 from gojek/remove_profile
Remove packaging ingestion as separate profile (fix #28)
2 parents 1ff6035 + 16ee0c7 commit dff75e0

1 file changed

Lines changed: 22 additions & 140 deletions

File tree

ingestion/pom.xml

Lines changed: 22 additions & 140 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
~
1717
-->
1818
<project xmlns="http://maven.apache.org/POM/4.0.0"
19-
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
20-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
19+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
20+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
2121
<modelVersion>4.0.0</modelVersion>
2222
<parent>
2323
<groupId>feast</groupId>
@@ -48,144 +48,31 @@
4848
<artifactId>maven-shade-plugin</artifactId>
4949
<version>3.2.1</version>
5050
<executions>
51-
<execution>
52-
<phase>package</phase>
53-
<goals>
54-
<goal>shade</goal>
55-
</goals>
56-
<configuration>
57-
<transformers>
58-
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
59-
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
60-
<mainClass>feast.ingestion.ImportJob</mainClass>
61-
</transformer>
62-
</transformers>
63-
</configuration>
64-
</execution>
51+
<execution>
52+
<phase>package</phase>
53+
<goals>
54+
<goal>shade</goal>
55+
</goals>
56+
<configuration>
57+
<transformers>
58+
<transformer
59+
implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
60+
<transformer
61+
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
62+
<mainClass>feast.ingestion.ImportJob</mainClass>
63+
</transformer>
64+
<transformer
65+
implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
66+
<resource>reference.conf</resource>
67+
</transformer>
68+
</transformers>
69+
</configuration>
70+
</execution>
6571
</executions>
6672
</plugin>
6773
</plugins>
6874
</build>
6975

70-
<profiles>
71-
<profile>
72-
<id>direct-runner</id>
73-
<dependencies>
74-
<dependency>
75-
<groupId>org.apache.beam</groupId>
76-
<artifactId>beam-runners-direct-java</artifactId>
77-
<version>${org.apache.beam.version}</version>
78-
<scope>runtime</scope>
79-
</dependency>
80-
</dependencies>
81-
<build>
82-
<plugins>
83-
<plugin>
84-
<groupId>org.apache.maven.plugins</groupId>
85-
<artifactId>maven-shade-plugin</artifactId>
86-
<version>3.2.1</version>
87-
<executions>
88-
<execution>
89-
<phase>package</phase>
90-
<goals>
91-
<goal>shade</goal>
92-
</goals>
93-
<configuration>
94-
<finalName>${project.artifactId}-direct</finalName>
95-
<transformers>
96-
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
97-
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
98-
<mainClass>feast.ingestion.ImportJob</mainClass>
99-
</transformer>
100-
</transformers>
101-
</configuration>
102-
</execution>
103-
</executions>
104-
</plugin>
105-
</plugins>
106-
</build>
107-
</profile>
108-
<profile>
109-
<id>flink-runner</id>
110-
<dependencies>
111-
<dependency>
112-
<groupId>org.apache.beam</groupId>
113-
<artifactId>beam-runners-flink_2.11</artifactId>
114-
<version>${org.apache.beam.version}</version>
115-
</dependency>
116-
</dependencies>
117-
<build>
118-
<plugins>
119-
<plugin>
120-
<groupId>org.apache.maven.plugins</groupId>
121-
<artifactId>maven-shade-plugin</artifactId>
122-
<version>3.2.1</version>
123-
<executions>
124-
<execution>
125-
<phase>package</phase>
126-
<goals>
127-
<goal>shade</goal>
128-
</goals>
129-
<configuration>
130-
<finalName>${project.artifactId}-flink</finalName>
131-
<transformers>
132-
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer">
133-
</transformer>
134-
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
135-
<mainClass>feast.ingestion.ImportJob</mainClass>
136-
</transformer>
137-
<transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
138-
<resource>reference.conf</resource>
139-
</transformer>
140-
</transformers>
141-
</configuration>
142-
</execution>
143-
</executions>
144-
</plugin>
145-
</plugins>
146-
</build>
147-
</profile>
148-
<profile>
149-
<id>dataflow-runner</id>
150-
<activation>
151-
<activeByDefault>true</activeByDefault>
152-
</activation>
153-
<dependencies>
154-
<dependency>
155-
<groupId>org.apache.beam</groupId>
156-
<artifactId>beam-runners-google-cloud-dataflow-java</artifactId>
157-
<version>${org.apache.beam.version}</version>
158-
</dependency>
159-
</dependencies>
160-
<build>
161-
<plugins>
162-
<plugin>
163-
<groupId>org.apache.maven.plugins</groupId>
164-
<artifactId>maven-shade-plugin</artifactId>
165-
<version>3.2.1</version>
166-
<executions>
167-
<execution>
168-
<phase>package</phase>
169-
<goals>
170-
<goal>shade</goal>
171-
</goals>
172-
<configuration>
173-
<finalName>${project.artifactId}-dataflow</finalName>
174-
<transformers>
175-
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
176-
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
177-
<mainClass>feast.ingestion.ImportJob</mainClass>
178-
</transformer>
179-
</transformers>
180-
</configuration>
181-
</execution>
182-
</executions>
183-
</plugin>
184-
</plugins>
185-
</build>
186-
</profile>
187-
</profiles>
188-
18976
<dependencies>
19077
<dependency>
19178
<groupId>org.hibernate.validator</groupId>
@@ -363,11 +250,6 @@
363250
<version>v2-rev394-1.22.0</version>
364251
</dependency>
365252

366-
<dependency>
367-
<groupId>com.google.guava</groupId>
368-
<artifactId>guava</artifactId>
369-
<version>25.1-jre</version>
370-
</dependency>
371253
<dependency>
372254
<groupId>com.google.code.gson</groupId>
373255
<artifactId>gson</artifactId>

0 commit comments

Comments
 (0)