fix: Resolve MyPy type error in MilvusOnlineStoreCreator

franciscojavierarceo · claude · franciscojavierarceo · commit de69e925f664 · 2026-02-01T22:59:35.000-05:00
- Fix return type annotation: Dict[str, Any] -&gt; dict[str, Any] to match base class
- Add missing OnlineStoreCreator import to repo_configuration.py
- Update type annotation from Dict[str, str] to Dict[str, Any] to support int values in Milvus config
- Remove unused Dict import after switching to lowercase dict

The enhanced MyPy configuration caught a real type incompatibility where MILVUS_CONFIG
contains integer values (embedding_dim: 2) but the type annotation only allowed strings.

Co-Authored-By: Claude Sonnet 4 &lt;noreply@anthropic.com&gt;
diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py
@@ -215,7 +215,7 @@
 # Replace online stores with emulated online stores if we're running local integration tests
 if os.getenv("FEAST_LOCAL_ONLINE_CONTAINER", "False").lower() == "true":
     replacements: Dict[
-        str, Tuple[Union[str, Dict[str, str]], Optional[Type[OnlineStoreCreator]]]
+        str, Tuple[Union[str, Dict[str, Any]], Optional[Type[OnlineStoreCreator]]]
     ] = {
         "redis": (REDIS_CONFIG, RedisOnlineStoreCreator),
         "milvus": (MILVUS_CONFIG, MilvusOnlineStoreCreator),
diff --git a/sdk/python/tests/integration/feature_repos/universal/online_store/milvus.py b/sdk/python/tests/integration/feature_repos/universal/online_store/milvus.py
@@ -1,4 +1,4 @@
-from typing import Any, Dict
+from typing import Any
 
 from tests.integration.feature_repos.universal.online_store_creator import (
     OnlineStoreCreator,
@@ -10,7 +10,7 @@ def __init__(self, project_name: str, **kwargs):
         super().__init__(project_name)
         self.db_path = "online_store.db"
 
-    def create_online_store(self) -> Dict[str, Any]:
+    def create_online_store(self) -> dict[str, Any]:
         return {
             "type": "milvus",
             "path": self.db_path,
