Skip to content

Commit dad2cd1

Browse files
zhilingczhilingc
authored andcommitted
Remove bigquery prefix
1 parent 9a4b44c commit dad2cd1

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

serving/src/main/resources/application.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ feast:
3838
# Please omit the trailing slash in the URI.
3939
staging_location: gs://mybucket/myprefix
4040
# Retry options for BigQuery retrieval jobs
41-
bigquery_initial_retry_delay_secs: 1
41+
initial_retry_delay_seconds: 1
4242
# BigQuery timeout for retrieval jobs
43-
bigquery_total_timeout_secs: 21600
43+
total_timeout_seconds: 21600
4444
subscriptions:
4545
- name: "*"
4646
project: "*"

storage/connectors/bigquery/src/main/java/feast/storage/connectors/bigquery/retriever/BigQueryHistoricalRetriever.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static HistoricalRetriever create(Map<String, String> config) {
5555
BigQuery bigquery = BigQueryOptions.getDefaultInstance().getService();
5656
Storage storage = StorageOptions.getDefaultInstance().getService();
5757

58-
String jobStagingLocation = config.get("staging-location");
58+
String jobStagingLocation = config.get("staging_location");
5959
if (!jobStagingLocation.contains("://")) {
6060
throw new IllegalArgumentException(
6161
String.format("jobStagingLocation is not a valid URI: %s", jobStagingLocation));
@@ -74,8 +74,8 @@ public static HistoricalRetriever create(Map<String, String> config) {
7474
.setDatasetId(config.get("dataset_id"))
7575
.setProjectId(config.get("project_id"))
7676
.setJobStagingLocation(config.get("staging_location"))
77-
.setInitialRetryDelaySecs(Integer.parseInt(config.get("bigquery_initial_retry_delay_secs")))
78-
.setTotalTimeoutSecs(Integer.parseInt(config.get("bigquery_total_timeout_secs")))
77+
.setInitialRetryDelaySecs(Integer.parseInt(config.get("initial_retry_delay_seconds")))
78+
.setTotalTimeoutSecs(Integer.parseInt(config.get("total_timeout_seconds")))
7979
.setStorage(storage)
8080
.build();
8181
}

0 commit comments

Comments
 (0)