Skip to content

Commit d7d9a5b

Browse files
removing makefile change
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
1 parent 9152d60 commit d7d9a5b

1 file changed

Lines changed: 3 additions & 15 deletions

File tree

infra/feast-operator/Makefile

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ endif
5151
OPERATOR_SDK_VERSION ?= v1.38.0
5252
# Image URL to use all building/pushing image targets
5353
IMG ?= $(IMAGE_TAG_BASE):$(VERSION)
54-
FS_IMG ?= docker.io/feastdev/feature-server:$(VERSION)
5554
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
5655
ENVTEST_K8S_VERSION = 1.30.0
5756

@@ -173,7 +172,7 @@ docker-buildx: ## Build and push docker image for the manager for cross-platform
173172
rm Dockerfile.cross
174173

175174
.PHONY: build-installer
176-
build-installer: manifests generate related-image-fs kustomize ## Generate a consolidated YAML with CRDs and deployment.
175+
build-installer: manifests generate kustomize ## Generate a consolidated YAML with CRDs and deployment.
177176
mkdir -p dist
178177
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
179178
$(KUSTOMIZE) build config/default > dist/install.yaml
@@ -193,7 +192,7 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified
193192
$(KUSTOMIZE) build config/crd | $(KUBECTL) delete --ignore-not-found=$(ignore-not-found) -f -
194193

195194
.PHONY: deploy
196-
deploy: manifests kustomize related-image-fs ## Deploy controller to the K8s cluster specified in ~/.kube/config.
195+
deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config.
197196
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
198197
$(KUSTOMIZE) build config/default | $(KUBECTL) apply -f -
199198

@@ -214,14 +213,12 @@ KUSTOMIZE ?= $(LOCALBIN)/kustomize
214213
CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen
215214
ENVTEST ?= $(LOCALBIN)/setup-envtest
216215
GOLANGCI_LINT = $(LOCALBIN)/golangci-lint
217-
ENVSUBST = $(LOCALBIN)/envsubst
218216

219217
## Tool Versions
220218
KUSTOMIZE_VERSION ?= v5.4.2
221219
CONTROLLER_TOOLS_VERSION ?= v0.15.0
222220
ENVTEST_VERSION ?= release-0.18
223221
GOLANGCI_LINT_VERSION ?= v1.59.1
224-
ENVSUBST_VERSION ?= v1.4.2
225222

226223
.PHONY: kustomize
227224
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.
@@ -243,11 +240,6 @@ golangci-lint: $(GOLANGCI_LINT) ## Download golangci-lint locally if necessary.
243240
$(GOLANGCI_LINT): $(LOCALBIN)
244241
$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/cmd/golangci-lint,$(GOLANGCI_LINT_VERSION))
245242

246-
.PHONY: envsubst
247-
envsubst: $(ENVSUBST) ## Download envsubst locally if necessary.
248-
$(ENVSUBST): $(LOCALBIN)
249-
$(call go-install-tool,$(ENVSUBST),github.com/a8m/envsubst/cmd/envsubst,$(ENVSUBST_VERSION))
250-
251243
# go-install-tool will 'go install' any package with custom target and name of binary, if it doesn't exist
252244
# $1 - target path with name of binary (ideally with version)
253245
# $2 - package url which can be installed
@@ -283,7 +275,7 @@ endif
283275
endif
284276

285277
.PHONY: bundle
286-
bundle: manifests kustomize related-image-fs operator-sdk ## Generate bundle manifests and metadata, then validate generated files.
278+
bundle: manifests kustomize operator-sdk ## Generate bundle manifests and metadata, then validate generated files.
287279
$(OPERATOR_SDK) generate kustomize manifests -q
288280
cd config/manager && $(KUSTOMIZE) edit set image controller=$(IMG)
289281
$(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle $(BUNDLE_GEN_FLAGS)
@@ -337,7 +329,3 @@ catalog-build: opm ## Build a catalog image.
337329
.PHONY: catalog-push
338330
catalog-push: ## Push a catalog image.
339331
$(MAKE) docker-push IMG=$(CATALOG_IMG)
340-
341-
.PHONY: related-image-fs
342-
related-image-fs: envsubst
343-
FS_IMG=$(FS_IMG) $(ENVSUBST) < config/default/related_image_fs_patch.tmpl > config/default/related_image_fs_patch.yaml

0 commit comments

Comments
 (0)