Fixed linting and unit tests

jyejare · jyejare · commit d5103255a79e · 2025-07-22T13:43:33.000+05:30
Signed-off-by: jyejare &lt;jyejare@redhat.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -1084,8 +1084,8 @@ def teardown(self):
 
     def get_historical_features(
         self,
-        features: Union[List[str], FeatureService],
         entity_df: Optional[Union[pd.DataFrame, str]] = None,
+        features: Union[List[str], FeatureService] = [],
         full_feature_names: bool = False,
         start_date: Optional[datetime] = None,
         end_date: Optional[datetime] = None,
@@ -1154,7 +1154,9 @@ def get_historical_features(
         """
 
         if entity_df is not None and (start_date is not None or end_date is not None):
-            raise ValueError("Cannot specify both entity_df and start_date/end_date. Use either entity_df for entity-based retrieval or start_date/end_date for timestamp range retrieval.")
+            raise ValueError(
+                "Cannot specify both entity_df and start_date/end_date. Use either entity_df for entity-based retrieval or start_date/end_date for timestamp range retrieval."
+            )
 
         if entity_df is None and end_date is None:
             end_date = datetime.now()
@@ -1192,6 +1194,13 @@ def get_historical_features(
         utils._validate_feature_refs(_feature_refs, full_feature_names)
         provider = self._get_provider()
 
+        # Optional kwargs
+        kwargs = {}
+        if start_date is not None:
+            kwargs["start_date"] = start_date
+        if end_date is not None:
+            kwargs["end_date"] = end_date
+
         job = provider.get_historical_features(
             self.config,
             feature_views,
@@ -1200,8 +1209,7 @@ def get_historical_features(
             self._registry,
             self.project,
             full_feature_names,
-            start_date,
-            end_date,
+            **kwargs,
         )
 
         return job
diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
@@ -124,12 +124,13 @@ def get_historical_features(
         registry: BaseRegistry,
         project: str,
         full_feature_names: bool = False,
-        start_date: Optional[datetime] = None,
-        end_date: Optional[datetime] = None,
+        **kwargs,
     ) -> RetrievalJob:
         assert isinstance(config.offline_store, PostgreSQLOfflineStoreConfig)
         for fv in feature_views:
             assert isinstance(fv.batch_source, PostgreSQLSource)
+        start_date: Optional[datetime] = kwargs.get("start_date", None)
+        end_date: Optional[datetime] = kwargs.get("end_date", None)
 
         # Handle non-entity retrieval mode
         if entity_df is None:
@@ -140,6 +141,7 @@ def get_historical_features(
                 end_date = make_tzaware(end_date)
 
             # Calculate start_date from TTL if not provided
+
             if start_date is None:
                 # Find the maximum TTL across all feature views to ensure we capture enough data
                 max_ttl_seconds = 0
@@ -157,9 +159,13 @@ def get_historical_features(
             else:
                 start_date = make_tzaware(start_date)
 
-            entity_df = pd.DataFrame({
-                'event_timestamp': pd.date_range(start=start_date, end=end_date, freq='1s', tz=timezone.utc)[:1]  # Just one row
-            })
+            entity_df = pd.DataFrame(
+                {
+                    "event_timestamp": pd.date_range(
+                        start=start_date, end=end_date, freq="1s", tz=timezone.utc
+                    )[:1]  # Just one row
+                }
+            )
 
         entity_schema = _get_entity_schema(entity_df, config)
 
@@ -564,7 +570,7 @@ def _get_entity_schema(
     {% endfor %}
 )
 
-SELECT 
+SELECT
     base.event_timestamp,
     {% set all_entities = [] %}
     {% for featureview in featureviews %}
diff --git a/sdk/python/feast/infra/offline_stores/offline_store.py b/sdk/python/feast/infra/offline_stores/offline_store.py
@@ -301,8 +301,6 @@ def get_historical_features(
         registry: BaseRegistry,
         project: str,
         full_feature_names: bool = False,
-        start_date: Optional[datetime] = None,
-        end_date: Optional[datetime] = datetime.now(),
     ) -> RetrievalJob:
         """
         Retrieves the point-in-time correct historical feature values for the specified entity rows.
@@ -319,6 +317,8 @@ def get_historical_features(
             full_feature_names: If True, feature names will be prefixed with the corresponding feature view name,
                 changing them from the format "feature" to "feature_view__feature" (e.g. "daily_transactions"
                 changes to "customer_fv__daily_transactions").
+
+        Keyword Args:
             start_date: Start date for the timestamp range when retrieving features without entity_df.
             end_date: End date for the timestamp range when retrieving features without entity_df. By default, the current time is used.
 
diff --git a/sdk/python/feast/infra/passthrough_provider.py b/sdk/python/feast/infra/passthrough_provider.py
@@ -462,8 +462,7 @@ def get_historical_features(
         registry: BaseRegistry,
         project: str,
         full_feature_names: bool,
-        start_date: Optional[datetime] = None,
-        end_date: Optional[datetime] = None,
+        **kwargs,
     ) -> RetrievalJob:
         job = self.offline_store.get_historical_features(
             config=config,
@@ -473,8 +472,7 @@ def get_historical_features(
             registry=registry,
             project=project,
             full_feature_names=full_feature_names,
-            start_date=start_date,
-            end_date=end_date,
+            **kwargs,
         )
 
         return job
diff --git a/sdk/python/feast/infra/provider.py b/sdk/python/feast/infra/provider.py
@@ -248,8 +248,7 @@ def get_historical_features(
         registry: BaseRegistry,
         project: str,
         full_feature_names: bool,
-        start_date: Optional[datetime] = None,
-        end_date: Optional[datetime] = None,
+        **kwargs,
     ) -> RetrievalJob:
         """
         Retrieves the point-in-time correct historical feature values for the specified entity rows.
diff --git a/sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.py b/sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.py
