Skip to content

Commit d34db1d

Browse files
checking in progress
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
1 parent adf147f commit d34db1d

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

sdk/python/feast/inference.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -283,18 +283,17 @@ def _infer_on_demand_features_and_entities(
283283

284284
batch_source = getattr(source_feature_view, "batch_source")
285285
batch_field_mapping = getattr(batch_source or None, "field_mapping")
286-
if batch_field_mapping:
287-
for (
288-
original_col,
289-
mapped_col,
290-
) in batch_field_mapping.items():
291-
if mapped_col in columns_to_exclude:
292-
columns_to_exclude.remove(mapped_col)
293-
columns_to_exclude.add(original_col)
286+
for (
287+
original_col,
288+
mapped_col,
289+
) in batch_field_mapping.items():
290+
if mapped_col in columns_to_exclude:
291+
columns_to_exclude.remove(mapped_col)
292+
columns_to_exclude.add(original_col)
294293

295-
table_column_names_and_types = (
296-
batch_source.get_table_column_names_and_types(config)
297-
)
294+
table_column_names_and_types = batch_source.get_table_column_names_and_types(
295+
config
296+
)
298297
for col_name, col_datatype in table_column_names_and_types:
299298
if col_name in columns_to_exclude:
300299
continue

sdk/python/feast/infra/online_stores/sqlite.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,16 +192,16 @@ def online_write_batch(
192192
),
193193
)
194194
else:
195-
# except Exception as e:
196-
print(
197-
f"error writing online batch for {table_name} - {feature_name} = {val}\n {e}"
198-
)
195+
# print(
196+
# f"error writing online batch for {table_name} - {feature_name} = {val}\n {e}"
197+
# )
199198
print(
200199
f'querying all records for table: {conn.execute(f"select * from {table_name}").fetchall()}'
201200
)
202201
r = conn.execute("""
203202
SELECT * FROM sqlite_master WHERE type='table' and name = 'test_on_demand_python_transformation_python_stored_writes_feature_view';
204203
""")
204+
print(f"table exists: {r.fetchall()}")
205205
if progress:
206206
progress(1)
207207

0 commit comments

Comments
 (0)