Skip to content

Commit d2e6d8c

Browse files
author
zhilingc
committed
Update featureRow proto to use fields, regenerate protos
1 parent c3e6d51 commit d2e6d8c

File tree

13 files changed

+598
-139
lines changed

13 files changed

+598
-139
lines changed

‎docs/storage.md‎

Whitespace-only changes.

‎protos/feast/types/FeatureRow.proto‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
syntax = "proto3";
1818

1919
import "google/protobuf/timestamp.proto";
20-
import "feast/types/Feature.proto";
20+
import "feast/types/Field.proto";
2121

2222
package feast.types;
2323

@@ -27,8 +27,8 @@ option go_package = "github.com/gojek/feast/protos/generated/go/feast/types";
2727

2828
message FeatureRow {
2929

30-
// Features in the feature row.
31-
repeated Feature features = 2;
30+
// Fields in the feature row.
31+
repeated Field fields = 2;
3232

3333
// Timestamp of the feature row. While the actual definition of this timestamp may vary
3434
// depending on the upstream feature creation pipelines, this is the timestamp that Feast

protos/feast/types/Feature.proto renamed to protos/feast/types/Field.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ option java_package = "feast.types";
2424
option java_outer_classname = "FeatureProto";
2525
option go_package = "github.com/gojek/feast/protos/generated/go/feast/types";
2626

27-
message Feature {
27+
message Field {
28+
string name = 1;
2829
feast.types.Value value = 2;
29-
string name = 3;
3030
}

‎protos/generated/go/feast/types/FeatureRow.pb.go‎

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎protos/generated/go/feast/types/Field.pb.go‎

Lines changed: 89 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sdk/python/feast/core/Source_pb2.py‎

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sdk/python/feast/core/Source_pb2.pyi‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@ class Source(google___protobuf___message___Message):
3838
def values(cls) -> typing___List[Source.SourceType]: ...
3939
@classmethod
4040
def items(cls) -> typing___List[typing___Tuple[str, Source.SourceType]]: ...
41-
KAFKA = typing___cast(Source.SourceType, 0)
42-
KAFKA = typing___cast(Source.SourceType, 0)
41+
INVALID = typing___cast(Source.SourceType, 0)
42+
KAFKA = typing___cast(Source.SourceType, 1)
43+
INVALID = typing___cast(Source.SourceType, 0)
44+
KAFKA = typing___cast(Source.SourceType, 1)
4345

4446
class OptionsEntry(google___protobuf___message___Message):
4547
DESCRIPTOR: google___protobuf___descriptor___Descriptor = ...

0 commit comments

Comments
 (0)