updates to fix linter and new signature for all implementations

franciscojavierarceo · franciscojavierarceo · commit d1c15cff2c14 · 2024-12-21T21:19:30.000-05:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py b/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
@@ -283,8 +283,8 @@ def retrieve_online_documents(
         self,
         config: RepoConfig,
         table: FeatureView,
-        requested_feature: str,
-        requested_features: List[str],
+        requested_feature: Optional[str],
+        requested_features: Optional[List[str]],
         embedding: List[float],
         top_k: int,
         distance_metric: Optional[str] = None,
@@ -315,7 +315,7 @@ def retrieve_online_documents(
             expr += f" && feature_name in [{features_str}]"
 
         output_fields = (
-            [composite_key_name] + requested_features + ["created_ts", "event_ts"]
+            [composite_key_name] + (requested_features if requested_features else []) + ["created_ts", "event_ts"]
         )
         assert all(
             field
