Skip to content

Commit d191c3d

Browse files
zhilingcfeast-ci-bot
zhilingc
authored and
feast-ci-bot
committed
Fix tag regex in tf file (#73)
* Add cloud-build config * Fix images list * Fix cloudbuild yaml build step args * Collapse image tags * Fix waitFor * Hard code tag for testing purposes * Remove hardcoded tags, and skiptests flag * Fix github tag regex in cloud build tf file * Remove base64 variable and move it inline
1 parent c691191 commit d191c3d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎testing/tf/cloud-build/cloud-build.tf‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
12
resource "google_cloudbuild_trigger" "build_trigger" {
23
project = "${var.gcp_project}"
34
trigger_template {
45
branch_name = "master"
5-
tag_name = "^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$"
6+
tag_name = "${base64decode("XigwfFsxLTldXFxkKilcXC4oMHxbMS05XVxcZCopXFwuKDB8WzEtOV1cXGQqKSg/Oi0oKD86MHxbMS05XVxcZCp8XFxkKlthLXpBLVotXVswLTlhLXpBLVotXSopKD86XFwuKD86MHxbMS05XVxcZCp8XFxkKlthLXpBLVotXVswLTlhLXpBLVotXSopKSopKT8oPzpcXCsoWzAtOWEtekEtWi1dKyg/OlxcLlswLTlhLXpBLVotXSspKikpPyQ=")}"
67
project = "${var.gcp_project}"
78
repo_name = "http://github.com/gojek/feast"
89
}

‎testing/tf/cloud-build/cloudbuild.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ steps:
1313
args: ['build', '-t', 'gcr.io/$PROJECT_ID/feast-serving:$TAG_NAME', '-t', 'gcr.io/$PROJECT_ID/feast-serving:latest', '--build-arg', 'RELEASE=$TAG_NAME', '-f', './docker/serving/Dockerfile', '.']
1414
id: docker-serving
1515
waitFor:
16-
1716
- build-jars
1817

1918
timeout: 1200s

0 commit comments

Comments
 (0)