fix: Fix field mapping logic during feature inference (#3067)

sfc-gh-madkins · web-flow · commit cdfa761a1620 · 2022-08-12T12:48:29.000-04:00
fix: Fix bug where feature inference was improperly registering timestamp and created field if part of field_mapping

Signed-off-by: Miles Adkins &lt;miles.adkins@snowflake.com&gt;

Signed-off-by: Miles Adkins &lt;miles.adkins@snowflake.com&gt;
diff --git a/sdk/python/feast/inference.py b/sdk/python/feast/inference.py
@@ -199,10 +199,10 @@ def _infer_features_and_entities(
         fv.batch_source.timestamp_field,
         fv.batch_source.created_timestamp_column,
     }
-    for column in columns_to_exclude:
-        if column in fv.batch_source.field_mapping:
-            columns_to_exclude.remove(column)
-            columns_to_exclude.add(fv.batch_source.field_mapping[column])
+    for original_col, mapped_col in fv.batch_source.field_mapping.items():
+        if mapped_col in columns_to_exclude:
+            columns_to_exclude.remove(mapped_col)
+            columns_to_exclude.add(original_col)
 
     table_column_names_and_types = fv.batch_source.get_table_column_names_and_types(
         config
