Skip to content

Commit cde8bbe

Browse files
committed
Update job controller tests
1 parent 4105a31 commit cde8bbe

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

job-controller/src/test/java/feast/jobcontroller/service/JobControllerIT.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
@SpringBootTest(
6666
properties = {
6767
"feast.jobs.enabled=true",
68+
"feast.jobs.job_id_prefix=test-prefix",
6869
"feast.jobs.polling_interval_milliseconds=1000",
6970
"feast.stream.specsOptions.notifyIntervalMilliseconds=1000",
7071
"feast.jobs.controller.consolidate-jobs-per-source=true",
@@ -166,6 +167,9 @@ public void shouldCreateJobForNewSource() {
166167

167168
assertThat(
168169
jobManager.getAllJobs(), containsInAnyOrder(hasProperty("id", equalTo(job.getId()))));
170+
assertThat(
171+
jobManager.getAllJobs(),
172+
containsInAnyOrder(hasProperty("id", containsString("test-prefix"))));
169173
}
170174

171175
@Test

job-controller/src/test/java/feast/jobcontroller/service/JobControllerServiceTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ public void setUp() {
7676
feastProperties = new FeastProperties();
7777
JobProperties jobProperties = new JobProperties();
7878
jobProperties.setJobUpdateTimeoutSeconds(5);
79+
jobProperties.setJobIdPrefix("test-prefix");
7980

8081
FeastProperties.JobProperties.ControllerProperties.FeatureSetSelector selector =
8182
new FeastProperties.JobProperties.ControllerProperties.FeatureSetSelector();
@@ -104,7 +105,7 @@ public void setUp() {
104105
specService,
105106
jobManager,
106107
feastProperties,
107-
new ConsolidatedJobStrategy(jobRepository),
108+
new ConsolidatedJobStrategy(jobRepository, feastProperties.getJobs()),
108109
mock(KafkaTemplate.class));
109110

110111
controllerWithJobPerStore =
@@ -113,7 +114,7 @@ public void setUp() {
113114
specService,
114115
jobManager,
115116
feastProperties,
116-
new JobPerStoreStrategy(jobRepository),
117+
new JobPerStoreStrategy(jobRepository, feastProperties.getJobs()),
117118
mock(KafkaTemplate.class));
118119
}
119120

@@ -286,6 +287,7 @@ public void shouldCreateJobIfNoRunning() {
286287
controllerWithConsolidation.makeJobUpdateTasks(
287288
ImmutableList.of(Pair.of(source, ImmutableSet.of(store))));
288289

290+
assertThat(tasks.get(0).getJob().getId(), containsString("test-prefix"));
289291
assertThat("CreateTask is expected", tasks.get(0) instanceof CreateJobTask);
290292
}
291293

0 commit comments

Comments
 (0)