Broaden google-cloud-core dependency (#2094)

ptoman-pa · web-flow · commit c7d0b108ba4d · 2021-12-02T12:08:03.000-08:00
* Broaden google-cloud-core dependency

Limiting google-cloud-core to 1.4.* seems tighter than it needs to be. The version 1.7.2 (which is the latest before 2.0.0) passes tests and makes feast more interoperable as a library with other systems.

Signed-off-by: Pamela Toman &lt;ptoman@paloaltonetworks.com&gt;

* Distinguish signing and signing off commits in contrib guidance

Signed-off-by: Pamela Toman &lt;ptoman@paloaltonetworks.com&gt;
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -25,15 +25,17 @@ pre-commit install --hook-type pre-commit --hook-type pre-push
 ```
 3. On push, the pre-commit hook will run. This runs `make format` and `make lint`.
 
-### Signing commits
-Use git signing to sign your commits. See 
+### Signing off commits
+Use git signoffs to sign your commits. See 
 https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification for details
 
-Then, you can sign commits with the `-s` flag:
+Then, you can sign off commits with the `-s` flag:
 ```
 git commit -s -m "My first commit"
 ```
 
+GPG-signing commits with `-S` is optional.
+
 ### Incorporating upstream changes from master
 Our preference is the use of `git rebase [master]` instead of `git merge` : `git pull -r`.
 
diff --git a/sdk/python/setup.py b/sdk/python/setup.py
@@ -73,7 +73,7 @@
     "google-cloud-bigquery-storage >= 2.0.0",
     "google-cloud-datastore>=2.1.*",
     "google-cloud-storage>=1.34.*,<1.41",
-    "google-cloud-core==1.4.*",
+    "google-cloud-core>=1.4.0,<2.0.0",
 ]
 
 REDIS_REQUIRED = [

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@`
`73`	`73`	`"google-cloud-bigquery-storage >= 2.0.0",`
`74`	`74`	`"google-cloud-datastore>=2.1.*",`
`75`	`75`	`"google-cloud-storage>=1.34.*,<1.41",`
`76`		`- "google-cloud-core==1.4.*",`
	`76`	`+ "google-cloud-core>=1.4.0,<2.0.0",`
`77`	`77`	`]`
`78`	`78`
`79`	`79`	`REDIS_REQUIRED = [`