fix: Update github workflow to prevent redis from overlapping ports. (#2350)

kevjumba · web-flow · commit c2a6c6cc34d6 · 2022-03-01T17:02:07.000-08:00
* Update redis port

Signed-off-by: Kevin Zhang &lt;kzhang@tecton.ai&gt;

* Add comment detailing why 12345 is port selected

Signed-off-by: Kevin Zhang &lt;kzhang@tecton.ai&gt;

* Keep redis at 6379 for now until we can test against new github workflow

Signed-off-by: Kevin Zhang &lt;kzhang@tecton.ai&gt;
diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml
@@ -102,6 +102,11 @@ jobs:
           # code from the PR.
           ref: refs/pull/${{ github.event.pull_request.number }}/merge
           submodules: recursive
+      - name: Start Redis
+        uses: supercharge/redis-github-action@1.4.0
+        with:
+          redis-version: ${{ matrix.redis-version }}
+          redis-port: 12345
       - name: Setup Python
         uses: actions/setup-python@v2
         id: setup-python
diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py
@@ -46,6 +46,7 @@
 )
 
 DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
+# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate.
 REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
 REDIS_CLUSTER_CONFIG = {
     "type": "redis",

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@`
`46`	`46`	`)`
`47`	`47`
`48`	`48`	`DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}`
	`49`	`+# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate.`
`49`	`50`	`REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}`
`50`	`51`	`REDIS_CLUSTER_CONFIG = {`
`51`	`52`	`"type": "redis",`