Implement changes from review

FredericKayser · FredericKayser · commit be9032235685 · 2025-10-29T14:45:33.000+01:00
Signed-off-by: Frederic Kayser &lt;frederic@frederic-kayser.de&gt;
diff --git a/infra/feast-operator/internal/controller/services/cronjob.go b/infra/feast-operator/internal/controller/services/cronjob.go
@@ -55,13 +55,9 @@ func (feast *FeastServices) setCronJob(cronJob *batchv1.CronJob) error {
 	appliedCronJob := feast.Handler.FeatureStore.Status.Applied.CronJob
 	cronJob.Labels = feast.getFeastTypeLabels(CronJobFeastType)
 	if appliedCronJob.Annotations != nil {
-		if cronJob.Annotations == nil {
-			cronJob.Annotations = make(map[string]string)
-		}
+		cronJob.Annotations = make(map[string]string, len(appliedCronJob.Annotations))
 		for k, v := range appliedCronJob.Annotations {
-			if _, exists := cronJob.Annotations[k]; !exists {
-				cronJob.Annotations[k] = v
-			}
+			cronJob.Annotations[k] = v
 		}
 	}
 	cronJob.Spec = batchv1.CronJobSpec{
