feast-dev
diff --git a/‎protos/feast/core/FeatureSet.proto‎
Lines changed: 5 additions & 3 deletions b/‎protos/feast/core/FeatureSet.proto‎
Lines changed: 5 additions & 3 deletions
diff --git a/‎protos/feast/core/Store.proto‎
Lines changed: 4 additions & 4 deletions b/‎protos/feast/core/Store.proto‎
Lines changed: 4 additions & 4 deletions
@@ -24,6 +24,7 @@ option go_package = "github.com/gojek/feast/protos/generated/go/feast/core";
 
 import "feast/types/Value.proto";
 import "feast/core/Source.proto";
+import "google/protobuf/duration.proto";
 
 message FeatureSetSpec {
     // Name of the featureSet. Must be unique.
@@ -41,9 +42,10 @@ message FeatureSetSpec {
     // List of features contained within this featureSet.
     repeated FeatureSpec features = 4;
 
-    // Features in this feature set will only be retrieved if they are found after [Time - MaxAge]
-    // Missing or older feature values will be returned as nulls and indicated to end user
-    int64 maxAge = 5;
+    // Features in this feature set will only be retrieved if they are found 
+    // after [time - max_age]. Missing or older feature values will be returned 
+    // as nulls and indicated to end user
+    google.protobuf.Duration max_age = 5;
 
     // Source on which feature rows can be found
     Source source = 6;
 
@@ -21,10 +21,10 @@ option java_package = "feast.core";
 option java_outer_classname = "StoreProto";
 option go_package = "github.com/gojek/feast/protos/generated/go/feast/core";
 
-// Store provides a location to which Feast reads and writes feature values.
+// Store provides a location where Feast reads and writes feature values.
 // Feature values will be written to the Store in the form of FeatureRow elements.
 // The way FeatureRow is encoded and decoded when it is written to and read from
-// the store depends on the type of the Store. 
+// the Store depends on the type of the Store.
 //
 // For example, a FeatureRow will materialize as a row in a table in 
 // BigQuery but it will materialize as a key, value pair element in Redis.
@@ -71,7 +71,7 @@ message Store {
     // - created_timestamp | TIMESTAMP        | processing time of the ingestion of the FeatureRow
     // - job_id            | STRING           | identifier for the job that writes the FeatureRow to the corresponding BigQuery table
     //
-    // BigQuery table created will be partitioned by the event_timestamp field 
+    // BigQuery table created will be partitioned by the field "event_timestamp"
     // of the FeatureRow (https://cloud.google.com/bigquery/docs/partitioned-tables).
     //
     // Since newer version of feature set can introduce breaking, non backward-
@@ -98,7 +98,7 @@ message Store {
     // FLOAT_LIST  : ARRAY
     // BOOL_LIST   : ARRAY
     //
-    // The column mode in BigQuery is set to Nullable such that unset Value 
+    // The column mode in BigQuery is set to "Nullable" such that unset Value
     // in a FeatureRow corresponds to NULL value in BigQuery.
     //
     BIGQUERY = 2;