feat: Set optional full-scan for deletion (#4189)

j1wonpark · web-flow · commit b9cadd53250f · 2024-05-26T20:15:59.000-04:00
diff --git a/sdk/python/feast/infra/online_stores/redis.py b/sdk/python/feast/infra/online_stores/redis.py
@@ -77,6 +77,9 @@ class RedisOnlineStoreConfig(FeastConfigBaseModel):
     key_ttl_seconds: Optional[int] = None
     """(Optional) redis key bin ttl (in seconds) for expiring entities"""
 
+    full_scan_for_deletion: Optional[bool] = True
+    """(Optional) whether to scan for deletion of features"""
+
 
 class RedisOnlineStore(OnlineStore):
     """
@@ -162,9 +165,13 @@ def update(
             entities_to_keep: Entities to keep
             partial: Whether to do a partial update
         """
+        online_store_config = config.online_store
+
+        assert isinstance(online_store_config, RedisOnlineStoreConfig)
 
-        for table in tables_to_delete:
-            self.delete_table(config, table)
+        if online_store_config.full_scan_for_deletion:
+            for table in tables_to_delete:
+                self.delete_table(config, table)
 
     def teardown(
         self,
