feat: Keep event type as complete instead of other

ntkathole · ntkathole · commit b743c1ef22ec · 2026-01-26T21:11:34.000+05:30
Signed-off-by: ntkathole &lt;nikhilkathole2683@gmail.com&gt;
diff --git a/sdk/python/feast/openlineage/emitter.py b/sdk/python/feast/openlineage/emitter.py
@@ -217,11 +217,11 @@ def emit_feature_view_lineage(
                 namespace=namespace,
             )
 
-            # Emit a RunEvent with OTHER state (metadata registration, not execution)
+            # Emit a RunEvent with COMPLETE state to create lineage connection
             result = self._client.emit_run_event(
                 job_name=job.name,
                 run_id=str(uuid.uuid4()),
-                event_type=RunState.OTHER,
+                event_type=RunState.COMPLETE,
                 inputs=inputs,
                 outputs=outputs,
                 job_facets=job.facets,
@@ -262,11 +262,11 @@ def emit_stream_feature_view_lineage(
                 namespace=namespace,
             )
 
-            # Emit a RunEvent with OTHER state (metadata registration, not execution)
+            # Emit a RunEvent with COMPLETE state to create lineage connection
             return self._client.emit_run_event(
                 job_name=f"stream_{job.name}",
                 run_id=str(uuid.uuid4()),
-                event_type=RunState.OTHER,
+                event_type=RunState.COMPLETE,
                 inputs=inputs,
                 outputs=outputs,
                 job_facets=job.facets,
@@ -353,11 +353,11 @@ def emit_on_demand_feature_view_lineage(
                 )
             }
 
-            # Emit a RunEvent with OTHER state (metadata registration, not execution)
+            # Emit a RunEvent with COMPLETE state to create lineage connection
             return self._client.emit_run_event(
                 job_name=f"on_demand_feature_view_{odfv.name}",
                 run_id=str(uuid.uuid4()),
-                event_type=RunState.OTHER,
+                event_type=RunState.COMPLETE,
                 inputs=inputs,
                 outputs=outputs,
                 job_facets=job_facets,
@@ -403,11 +403,11 @@ def emit_feature_service_lineage(
                 namespace=namespace,
             )
 
-            # Emit a RunEvent with OTHER state (metadata registration, not execution)
+            # Emit a RunEvent with COMPLETE state to create lineage connection
             return self._client.emit_run_event(
                 job_name=job.name,
                 run_id=str(uuid.uuid4()),
-                event_type=RunState.OTHER,
+                event_type=RunState.COMPLETE,
                 inputs=inputs,
                 outputs=outputs,
                 job_facets=job.facets,
@@ -851,7 +851,7 @@ def emit_apply(
                 result1 = self._client.emit_run_event(
                     job_name=f"feast_feature_views_{project}",
                     run_id=str(uuid.uuid4()),
-                    event_type=RunState.OTHER,
+                    event_type=RunState.COMPLETE,
                     inputs=fv_inputs,
                     outputs=fv_outputs,
                     job_facets=job_facets,
@@ -967,7 +967,7 @@ def emit_apply(
                 result = self._client.emit_run_event(
                     job_name=f"feature_service_{fs.name}",  # Prefix to avoid conflict with dataset
                     run_id=str(uuid.uuid4()),
-                    event_type=RunState.OTHER,
+                    event_type=RunState.COMPLETE,
                     inputs=fs_inputs,
                     outputs=[fs_output],
                     job_facets=job_facets,
diff --git a/sdk/python/tests/doctest/test_all.py b/sdk/python/tests/doctest/test_all.py
@@ -79,7 +79,11 @@ def test_docstrings():
                     full_name = package.__name__ + "." + name
                     try:
                         # https://github.com/feast-dev/feast/issues/5088
-                        if "ikv" not in full_name and "milvus" not in full_name:
+                        if (
+                            "ikv" not in full_name
+                            and "milvus" not in full_name
+                            and "openlineage" not in full_name
+                        ):
                             temp_module = importlib.import_module(full_name)
                             if is_pkg:
                                 next_packages.append(temp_module)
