Skip to content

Commit b3de2cf

Browse files
ntkatholecursoragent
ntkathole
and
cursoragent
authored
chore: Remove unused hermeto offline tree and sdist requirement locks (#6987)
* chore: Remove unused multicloud hermeto offline build tree Drop sdk/python/feast/infra/feature_servers/multicloud/offline/, which only supported local hermeto/arrow-from-source and RPM lock offline image builds and is unused by Makefile CI, GitHub Actions, or the standard feature-server Dockerfiles. Also clear related .secrets.baseline entries. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore: Drop unused minimal-sdist requirement locks Remove py3.10–3.12 minimal-sdist(-build) lockfiles, stop generating them in lock-python-dependencies-all, and delete the minimal-sdist-build extra. They only supported hermeto build-from-sdist offline image builds. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore: Refresh pixi.lock after removing minimal-sdist-build Keep pixi install --locked in sync with the pyproject.toml optional dependency change so ray/duckdb CI environments can install. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent e8dbd50 commit b3de2cf

24 files changed

Lines changed: 0 additions & 18462 deletions

‎.secrets.baseline‎

Lines changed: 0 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Makefile‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -155,17 +155,6 @@ lock-python-dependencies-all: ## Recompile and lock all Python dependency sets f
155155
pixi run --environment $(call get_env_name,$(ver)) --manifest-path infra/scripts/pixi/pixi.toml \
156156
"uv pip compile -p $(ver) --no-strip-extras pyproject.toml --extra minimal \
157157
--generate-hashes --output-file sdk/python/requirements/py$(ver)-minimal-requirements.txt" && \
158-
pixi run --environment $(call get_env_name,$(ver)) --manifest-path infra/scripts/pixi/pixi.toml \
159-
"uv pip compile -p $(ver) --no-strip-extras pyproject.toml --extra minimal-sdist-build \
160-
--no-emit-package milvus-lite \
161-
--no-emit-package pymilvus \
162-
--no-emit-package faiss-cpu \
163-
--generate-hashes --output-file sdk/python/requirements/py$(ver)-minimal-sdist-requirements.txt" && \
164-
pixi run --environment $(call get_env_name,$(ver)) --manifest-path infra/scripts/pixi/pixi.toml \
165-
"uv pip install -p $(ver) pybuild-deps==0.5.0 pip==25.0.1 typing_extensions && \
166-
pybuild-deps compile --generate-hashes \
167-
-o sdk/python/requirements/py$(ver)-minimal-sdist-requirements-build.txt \
168-
sdk/python/requirements/py$(ver)-minimal-sdist-requirements.txt" && \
169158
) true
170159

171160
compile-protos-python: ## Compile Python protobuf files

‎pixi.lock‎

Lines changed: 0 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pyproject.toml‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -221,28 +221,6 @@ dev = ["feast[ci]"]
221221
docs = ["feast[ci]"]
222222
# used for the 'feature-server' container image build
223223
minimal = ["feast[aws, gcp, snowflake, redis, go, mysql, postgres-c, opentelemetry, grpcio, k8s, duckdb, mcp, milvus, mcp-server]"]
224-
minimal-sdist-build = [
225-
"feast[minimal]",
226-
"feast[ibis]",
227-
"meson<1.7.2",
228-
"pybindgen==0.22.0",
229-
"sphinx!=4.0.0",
230-
"types_psutil<7.0.0.20250401",
231-
232-
# sqlalchemy[mypy] dep
233-
"greenlet!=0.4.17",
234-
235-
# numpy deps
236-
"meson-python<0.16.0,>=0.15.0",
237-
"Cython<3.1,>=0.29.34",
238-
"flit_core<4,>=3.8",
239-
"patchelf>=0.11.0",
240-
"scikit-build-core>=0.10",
241-
"hatch-fancy-pypi-readme>=23.2.0",
242-
"hatch-vcs==0.4.0",
243-
"hatchling>=1.6.0,<2",
244-
"calver<2025.4.1",
245-
]
246224
setuptools = [
247225
# https://amitylearning.vercel.app/?question=git-1742419854670&update=1742342400027
248226
"setuptools>=60,<81",

‎sdk/python/feast/infra/feature_servers/multicloud/offline/.gitignore‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.binary‎

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.binary.release‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.builder.yarn‎

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.builder.yum‎

Lines changed: 0 additions & 13 deletions
This file was deleted.

‎sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.sdist‎

Lines changed: 0 additions & 166 deletions
This file was deleted.

0 commit comments

Comments
 (0)