feat: pass requested ODFVs into provider.get_historical_features

Shizoqua · Shizoqua · commit b2d82b64a4b1 · 2025-12-31T01:17:41.000+01:00
Signed-off-by: Shizoqua &lt;hr.lanreshittu@yahoo.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -1218,6 +1218,7 @@ def get_historical_features(
         job = provider.get_historical_features(
             self.config,
             feature_views,
+            on_demand_feature_views,
             _feature_refs,
             entity_df,
             self._registry,
diff --git a/sdk/python/feast/infra/passthrough_provider.py b/sdk/python/feast/infra/passthrough_provider.py
@@ -459,13 +459,15 @@ def get_historical_features(
         self,
         config: RepoConfig,
         feature_views: List[Union[FeatureView, OnDemandFeatureView]],
+        on_demand_feature_views: List[OnDemandFeatureView],
         feature_refs: List[str],
         entity_df: Optional[Union[pd.DataFrame, str]],
         registry: BaseRegistry,
         project: str,
         full_feature_names: bool,
         **kwargs,
     ) -> RetrievalJob:
+        del on_demand_feature_views
         job = self.offline_store.get_historical_features(
             config=config,
             feature_views=feature_views,
diff --git a/sdk/python/feast/infra/provider.py b/sdk/python/feast/infra/provider.py
@@ -250,6 +250,7 @@ def get_historical_features(
         self,
         config: RepoConfig,
         feature_views: List[Union[FeatureView, OnDemandFeatureView]],
+        on_demand_feature_views: List[OnDemandFeatureView],
         feature_refs: List[str],
         entity_df: Optional[Union[pd.DataFrame, str]],
         registry: BaseRegistry,
@@ -263,6 +264,7 @@ def get_historical_features(
         Args:
             config: The config for the current feature store.
             feature_views: A list containing all feature views that are referenced in the entity rows.
+            on_demand_feature_views: The on demand feature views requested as part of the retrieval.
             feature_refs: The features to be retrieved.
             entity_df: A collection of rows containing all entity columns on which features need to be joined,
                 as well as the timestamp column used for point-in-time joins. Either a pandas dataframe can be
