Skip to content

Commit b2c76ff

Browse files
abhijeet-dhumalntkathole
authored andcommitted
fix: allow offline-only BatchFeatureView to skip online validation in get_historical_features
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
1 parent 7639c2a commit b2c76ff

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,9 +1296,10 @@ def _get_feature_views_to_materialize(
12961296
f"Enable it before materializing."
12971297
)
12981298
if hasattr(feature_view, "online") and not feature_view.online:
1299-
raise ValueError(
1300-
f"FeatureView {feature_view.name} is not configured to be served online."
1301-
)
1299+
if not getattr(feature_view, "offline", False):
1300+
raise ValueError(
1301+
f"FeatureView {feature_view.name} is not configured to be served online."
1302+
)
13021303
elif (
13031304
hasattr(feature_view, "write_to_online_store")
13041305
and not feature_view.write_to_online_store

0 commit comments

Comments
 (0)