Skip to content

Commit ad8f572

Browse files
authored
fix: Remove proto-plus imports (#4044)
remove proto-plus imports Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
1 parent c364be4 commit ad8f572

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

sdk/python/feast/base_feature_view.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,20 @@
1313
# limitations under the License.
1414
from abc import ABC, abstractmethod
1515
from datetime import datetime
16-
from typing import Dict, List, Optional, Type
16+
from typing import Dict, List, Optional, Type, Union
1717

1818
from google.protobuf.json_format import MessageToJson
19-
from proto import Message
19+
from google.protobuf.message import Message
2020

2121
from feast.feature_view_projection import FeatureViewProjection
2222
from feast.field import Field
23+
from feast.protos.feast.core.FeatureView_pb2 import FeatureView as FeatureViewProto
24+
from feast.protos.feast.core.OnDemandFeatureView_pb2 import (
25+
OnDemandFeatureView as OnDemandFeatureViewProto,
26+
)
27+
from feast.protos.feast.core.StreamFeatureView_pb2 import (
28+
StreamFeatureView as StreamFeatureViewProto,
29+
)
2330

2431

2532
class BaseFeatureView(ABC):
@@ -89,7 +96,9 @@ def proto_class(self) -> Type[Message]:
8996
pass
9097

9198
@abstractmethod
92-
def to_proto(self) -> Message:
99+
def to_proto(
100+
self,
101+
) -> Union[FeatureViewProto, OnDemandFeatureViewProto, StreamFeatureViewProto]:
93102
pass
94103

95104
@classmethod

sdk/python/feast/infra/registry/base_registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from typing import Any, Dict, List, Optional
2020

2121
from google.protobuf.json_format import MessageToJson
22-
from proto import Message
22+
from google.protobuf.message import Message
2323

2424
from feast.base_feature_view import BaseFeatureView
2525
from feast.data_source import DataSource

sdk/python/feast/infra/registry/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from urllib.parse import urlparse
2121

2222
from google.protobuf.internal.containers import RepeatedCompositeFieldContainer
23-
from proto import Message
23+
from google.protobuf.message import Message
2424

2525
from feast import usage
2626
from feast.base_feature_view import BaseFeatureView

0 commit comments

Comments
 (0)