Skip to content

Commit ac0f1df

Browse files
jklegarjklegar
authored
disable telemetry in docker-compose test and job_service (#1297)
* fix docker-compose test Signed-off-by: Jacob Klegar <jacob@tecton.ai> * disable telemetry in client that job_service uses Signed-off-by: Jacob Klegar <jacob@tecton.ai>
1 parent 34949e6 commit ac0f1df

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎infra/scripts/test-docker-compose.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,4 @@ docker exec \
7070
-e DISABLE_FEAST_SERVICE_FIXTURES=true \
7171
--user root \
7272
feast_jupyter_1 bash \
73-
-c 'cd /feast/tests && python -m pip install -r requirements.txt && pytest e2e/ --ingestion-jar https://storage.googleapis.com/feast-jobs/spark/ingestion/feast-ingestion-spark-${FEAST_VERSION}.jar --redis-url redis:6379 --core-url core:6565 --serving-url online_serving:6566 --job-service-url jobservice:6568 --staging-path file:///shared/staging/ --kafka-brokers kafka:9092 --statsd-url prometheus_statsd:9125 --prometheus-url prometheus_statsd:9102 --feast-version develop'
73+
-c 'cd /feast/tests && python -m pip install -r requirements.txt && FEAST_TELEMETRY=False pytest e2e/ --ingestion-jar https://storage.googleapis.com/feast-jobs/spark/ingestion/feast-ingestion-spark-${FEAST_VERSION}.jar --redis-url redis:6379 --core-url core:6565 --serving-url online_serving:6566 --job-service-url jobservice:6568 --staging-path file:///shared/staging/ --kafka-brokers kafka:9092 --statsd-url prometheus_statsd:9125 --prometheus-url prometheus_statsd:9102 --feast-version develop'

‎sdk/python/feast/job_service.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ def start_control_loop() -> None:
218218
"which will ensure that stream ingestion jobs are successfully running."
219219
)
220220
try:
221-
client = feast.Client()
221+
client = feast.Client(telemetry="False")
222222
while True:
223223
ensure_stream_ingestion_jobs(client, all_projects=True)
224224
time.sleep(1)
@@ -248,7 +248,7 @@ def start_job_service() -> None:
248248
log_fmt = "%(asctime)s %(levelname)s %(message)s"
249249
logging.basicConfig(level=logging.INFO, format=log_fmt)
250250

251-
client = feast.Client()
251+
client = feast.Client(telemetry="False")
252252

253253
if client._config.getboolean(opt.JOB_SERVICE_ENABLE_CONTROL_LOOP):
254254
# Start the control loop thread only if it's enabled from configs

0 commit comments

Comments
 (0)