fix bigquery source

adchia · adchia · commit aad4b7786006 · 2022-03-01T21:34:58.000-05:00
Signed-off-by: Danny Chiao &lt;danny@tecton.ai&gt;
diff --git a/sdk/python/feast/infra/offline_stores/bigquery_source.py b/sdk/python/feast/infra/offline_stores/bigquery_source.py
@@ -44,14 +44,15 @@ def __init__(
          """
         if table is None and table_ref is None and query is None:
             raise ValueError('No "table" argument provided.')
-        if table_ref:
+        if not table and table_ref:
             warnings.warn(
                 (
                     "The argument 'table_ref' is being deprecated. Please use 'table' "
                     "instead. Feast 0.20 and onwards will not support the argument 'table_ref'."
                 ),
                 DeprecationWarning,
             )
+            table = table_ref
         self.bigquery_options = BigQueryOptions(table_ref=table, query=query)
 
         # If no name, use the table_ref as the default name
diff --git a/sdk/python/tests/example_repos/example_feature_repo_1.py b/sdk/python/tests/example_repos/example_feature_repo_1.py
@@ -10,7 +10,7 @@
 )
 
 driver_locations_source = BigQuerySource(
-    table_ref="feast-oss.public.drivers",
+    table="feast-oss.public.drivers",
     event_timestamp_column="event_timestamp",
     created_timestamp_column="created_timestamp",
 )

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`driver_locations_source = BigQuerySource(`
`13`		`- table_ref="feast-oss.public.drivers",`
	`13`	`+ table="feast-oss.public.drivers",`
`14`	`14`	`event_timestamp_column="event_timestamp",`
`15`	`15`	`created_timestamp_column="created_timestamp",`
`16`	`16`	`)`