Skip to content

Commit aa7b685

Browse files
larrysingleton007ntkathole
authored andcommitted
test: Remove flaky key encoding timing assertion
Fixes #6745 Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com>
1 parent 602d752 commit aa7b685

1 file changed

Lines changed: 0 additions & 26 deletions

File tree

sdk/python/tests/unit/infra/test_key_encoding_utils.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -236,32 +236,6 @@ def test_optimization_preserves_sorting():
236236
assert [v.string_val for v in deserialized.entity_values] == expected_sorted_values
237237

238238

239-
def test_performance_bounds_single_entity():
240-
"""Regression test to ensure single entity performance meets minimum bounds."""
241-
import time
242-
243-
entity_key = EntityKeyProto(
244-
join_keys=["user_id"], entity_values=[ValueProto(string_val="user123")]
245-
)
246-
247-
# Measure serialization time for 1000 operations
248-
start = time.perf_counter()
249-
for _ in range(1000):
250-
serialize_entity_key(entity_key, entity_key_serialization_version=3)
251-
serialize_time = time.perf_counter() - start
252-
253-
# Measure deserialization time
254-
serialized = serialize_entity_key(entity_key, entity_key_serialization_version=3)
255-
start = time.perf_counter()
256-
for _ in range(1000):
257-
deserialize_entity_key(serialized, entity_key_serialization_version=3)
258-
deserialize_time = time.perf_counter() - start
259-
260-
# Performance bounds with generous thresholds to avoid flaky failures on CI runners
261-
assert serialize_time < 0.2, f"Serialization too slow: {serialize_time:.4f}s"
262-
assert deserialize_time < 0.2, f"Deserialization too slow: {deserialize_time:.4f}s"
263-
264-
265239
def test_non_ascii_prefix_compatibility():
266240
"""Critical test: ensure prefix serialization matches full entity key serialization for non-ASCII keys."""
267241
# Test with non-ASCII characters that have different byte vs character lengths

0 commit comments

Comments
 (0)