Removing some unnecessary code

franciscojavierarceo · franciscojavierarceo · commit a639013d5cbc · 2024-12-21T21:19:30.000-05:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py b/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
@@ -341,7 +341,6 @@ def retrieve_online_documents(
             anns_field=ann_search_field,
             param=search_params,
             limit=top_k,
-            # expr=expr,
             output_fields=output_fields,
             consistency_level="Strong",
         )
diff --git a/sdk/python/tests/conftest.py b/sdk/python/tests/conftest.py
@@ -207,17 +207,10 @@ def environment(request, worker_id):
 
 @pytest.fixture
 def vectordb_environment(request, worker_id):
-    db_config = IntegrationTestRepoConfig(
-        provider="local",
-        # online_store="milvus",
-        # online_store_creator=MilvusOnlineStoreCreator,
-        # offline_store_creator=FileDataSourceCreator,
-    )
-    print(request)
     e = construct_test_environment(
-        db_config,
-        fixture_request=request,
+        request.param,
         worker_id=worker_id,
+        fixture_request=request,
         entity_key_serialization_version=3,
     )
 
diff --git a/sdk/python/tests/integration/feature_repos/universal/online_store/milvus.py b/sdk/python/tests/integration/feature_repos/universal/online_store/milvus.py
@@ -32,5 +32,4 @@ def create_online_store(self) -> Dict[str, Any]:
         }
 
     def teardown(self):
-        # assert 1 == 4
         self.container.stop()

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,6 @@ def retrieve_online_documents(`
`341`	`341`	`anns_field=ann_search_field,`
`342`	`342`	`param=search_params,`
`343`	`343`	`limit=top_k,`
`344`		`- # expr=expr,`
`345`	`344`	`output_fields=output_fields,`
`346`	`345`	`consistency_level="Strong",`
`347`	`346`	`)`
Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,4 @@ def create_online_store(self) -> Dict[str, Any]:`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`def teardown(self):`
`35`		`- # assert 1 == 4`
`36`	`35`	`self.container.stop()`