Skip to content

Commit a19a1fa

Browse files
pyalexachals
authored andcommitted
add comment
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
1 parent 9d16da7 commit a19a1fa

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

sdk/python/feast/feature_logging.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ def get_schema(self, registry: "Registry") -> pa.Schema:
5252
fields: Dict[str, pa.DataType] = {}
5353

5454
for projection in self._feature_service.feature_view_projections:
55+
# The order of fields in the generated schema should match
56+
# the order created on the other side (inside Go logger).
57+
# Otherwise, some offline stores might not accept parquet files (produced by Go).
58+
# Go code can be found here:
59+
# https://github.com/feast-dev/feast/blob/master/go/internal/feast/server/logging/memorybuffer.go#L51
5560
try:
5661
feature_view = registry.get_feature_view(projection.name, self._project)
5762
except FeatureViewNotFoundException:

0 commit comments

Comments
 (0)