Skip to content

Commit a1207b5

Browse files
terryyylimTerence
andauthored
Add missing key count metric (#816)
* Add missing key count metric * Refactor metrics counter * Rename function Co-authored-by: Terence <terence.limxp@go-jek.com>
1 parent a16d7ee commit a1207b5

2 files changed

Lines changed: 7 additions & 12 deletions

File tree

serving/src/main/java/feast/serving/service/OnlineServingService.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public GetOnlineFeaturesResponse getOnlineFeatures(GetOnlineFeaturesRequest requ
123123
entityStatusesMap.get(entityRow).putAll(statusMap);
124124

125125
// Populate metrics/log request
126-
populateStaleKeyCountMetrics(statusMap, featureSetRequest);
126+
populateCountMetrics(statusMap, featureSetRequest);
127127
});
128128
populateRequestCountMetrics(featureSetRequest);
129129
logFeatureRows.add(featureRows);
@@ -287,7 +287,7 @@ private void logFeatureRowsTrace(
287287
scope.span().log(ImmutableMap.of("event", "featureRows", "value", loggableFeatureRows));
288288
}
289289

290-
private void populateStaleKeyCountMetrics(
290+
private void populateCountMetrics(
291291
Map<String, FieldStatus> statusMap, FeatureSetRequest featureSetRequest) {
292292
String project = featureSetRequest.getSpec().getProject();
293293
statusMap
@@ -296,6 +296,9 @@ private void populateStaleKeyCountMetrics(
296296
es -> {
297297
String featureRefString = es.getKey();
298298
FieldStatus status = es.getValue();
299+
if (status == FieldStatus.NOT_FOUND) {
300+
Metrics.notFoundKeyCount.labels(project, featureRefString).inc();
301+
}
299302
if (status == FieldStatus.OUTSIDE_MAX_AGE) {
300303
Metrics.staleKeyCount.labels(project, featureRefString).inc();
301304
}

serving/src/main/java/feast/serving/util/Metrics.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,14 @@ public class Metrics {
3838
.labelNames("project", "feature_name")
3939
.register();
4040

41-
public static final Counter missingKeyCount =
41+
public static final Counter notFoundKeyCount =
4242
Counter.build()
43-
.name("missing_feature_count")
43+
.name("not_found_feature_count")
4444
.subsystem("feast_serving")
4545
.help("number requested feature rows that were not found")
4646
.labelNames("project", "feature_name")
4747
.register();
4848

49-
public static final Counter invalidEncodingCount =
50-
Counter.build()
51-
.name("invalid_encoding_feature_count")
52-
.subsystem("feast_serving")
53-
.help("number requested feature rows that were stored with the wrong encoding")
54-
.labelNames("project", "feature_name")
55-
.register();
56-
5749
public static final Counter staleKeyCount =
5850
Counter.build()
5951
.name("stale_feature_count")

0 commit comments

Comments
 (0)