Prevent throwing RuntimeException when invalid proto is received (#166)

pradithya · feast-ci-bot · commit a0111bb4a3bf · 2019-03-29T12:01:28.000+08:00
diff --git a/ingestion/src/main/java/feast/store/errors/json/JsonFileErrorsWrite.java b/ingestion/src/main/java/feast/store/errors/json/JsonFileErrorsWrite.java
@@ -39,18 +39,24 @@ public class JsonFileErrorsWrite extends FeatureStoreWrite {
 
   @Override
   public PDone expand(PCollection<FeatureRowExtended> input) {
-    return input.apply("Map to strings", MapElements.into(kvs(strings(), strings())).via(
-        (rowExtended) -> {
-          try {
-            return KV.of(
-                rowExtended.getRow().getEntityName(),
-                JsonFormat.printer().omittingInsignificantWhitespace()
-                    .print(rowExtended)
-            );
-          } catch (InvalidProtocolBufferException e) {
-            throw new RuntimeException(e);
-          }
-        }
-    )).apply("Write Error Json Files", new TextFileDynamicIO.Write(options, ".json"));
+    return input
+        .apply(
+            "Map to strings",
+            MapElements.into(kvs(strings(), strings()))
+                .via(
+                    (rowExtended) -> {
+                      try {
+                        return KV.of(
+                            rowExtended.getRow().getEntityName(),
+                            JsonFormat.printer()
+                                .omittingInsignificantWhitespace()
+                                .print(rowExtended));
+                      } catch (InvalidProtocolBufferException e) {
+                        return KV.of(
+                            rowExtended.getRow().getEntityName(),
+                            e.toString());
+                      }
+                    }))
+        .apply("Write Error Json Files", new TextFileDynamicIO.Write(options, ".json"));
   }
 }
