Skip to content

Commit 9eb3d29

Browse files
abhijeet-dhumalntkathole
authored andcommitted
fix: allow offline-only BatchFeatureView to skip online validation in get_historical_features
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
1 parent 94ad0fb commit 9eb3d29

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,9 +1058,10 @@ def _get_feature_views_to_materialize(
10581058
f"Enable it before materializing."
10591059
)
10601060
if hasattr(feature_view, "online") and not feature_view.online:
1061-
raise ValueError(
1062-
f"FeatureView {feature_view.name} is not configured to be served online."
1063-
)
1061+
if not getattr(feature_view, "offline", False):
1062+
raise ValueError(
1063+
f"FeatureView {feature_view.name} is not configured to be served online."
1064+
)
10641065
elif (
10651066
hasattr(feature_view, "write_to_online_store")
10661067
and not feature_view.write_to_online_store

0 commit comments

Comments
 (0)