verify python wheel before publish

pyalex · pyalex · commit 9db1f56f06dd · 2022-05-13T09:24:41.000-07:00
Signed-off-by: Oleksii Moskalenko &lt;moskalenko.alexey@gmail.com&gt;
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -4,6 +4,7 @@ on:
   push:
     tags:
       - 'v*.*.*'
+  workflow_dispatch:
 
 jobs:
   get-version:
@@ -140,23 +141,63 @@ jobs:
 
 
   verify-python-wheel:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     needs: [build-python-sdk, build-python-sdk-macos-py310]
+    strategy:
+      matrix:
+        os: [ ubuntu-latest, macos-10.15 ]
+        python-version: [ "3.8", "3.9", "3.10"]
+        from-source: [ True, False ]
     steps:
       - name: Setup Python
         id: setup-python
         uses: actions/setup-python@v2
         with:
-          python-version: "3.8"
+          python-version: ${{ matrix.python-version }}
           architecture: x64
       - uses: actions/download-artifact@v2
         with:
           name: wheels
           path: dist
       - name: Install wheel
-        run: pip install dist/*38*linux*.whl
+        if: ${{ !matrix.from-source }}
+        # try to install all wheels; only the current platform wheel should be actually installed
+        run: |
+          cd dist/
+          for f in *.whl; do pip install $f || true; done
       - name: Install sdist
+        if: ${{ matrix.from-source }}
         run: pip install dist/*tar.gz
+      - name: Install OS X dependencies
+        if: ${{ matrix.os == "macos-10.15" }}
+        run: brew install coreutils
+      - name: Smoke test
+        env:
+          # this script is for testing servers
+          # it starts server with timeout and checks whether process killed by timeout (started healthy) or died by itself
+          TEST_SCRIPT: |
+            timeout 10s $@ & pid=$!
+            wait $pid
+            ret=$?
+            if [[ $ret -ne 124 ]]
+            then
+               exit $ret
+            else
+               echo "Succeeded!"
+            fi
+        run: |
+          feast init test_repo
+          cd test_repo/
+          feast apply
+          echo "$TEST_SCRIPT" > run-and-wait.sh
+          cat run-and-wait.sh
+          bash run-and-wait.sh feast serve
+          bash run-and-wait.sh feast ui
+      - name: Go lib test
+        if: ${{ !matrix.from-source }}
+        run: |
+          echo "\ngo_feature_retrieval: True" >> feature_store.yaml
+          bash run-and-wait.sh feast serve
 
   build-python-sdk:
     name: Build wheels on ${{ matrix.os }}
@@ -171,24 +212,27 @@ jobs:
         with:
           node-version: '17.x'
           registry-url: 'https://registry.npmjs.org'
+      - name: Build UI
+        run: make build-ui
       - name: Build wheels
         uses: pypa/cibuildwheel@v2.4.0
         env:
           CIBW_BUILD: "cp3*_x86_64"
           CIBW_SKIP: "cp36-* *-musllinux_x86_64 cp310-macosx_x86_64"
           CIBW_ARCHS: "native"
           CIBW_ENVIRONMENT: >
-            COMPILE_GO=True
+            COMPILE_GO=True PATH=$PATH:/usr/local/go/bin
           CIBW_BEFORE_ALL_LINUX: |
-            yum install -y golang
+            curl -o go.tar.gz https://dl.google.com/go/go1.18.2.linux-amd64.tar.gz
+            tar -C /usr/local -xzf go.tar.gz
+            go version
           CIBW_BEFORE_ALL_MACOS: |
             curl -o python.pkg https://www.python.org/ftp/python/3.9.12/python-3.9.12-macosx10.9.pkg
             sudo installer -pkg python.pkg -target /
           CIBW_BEFORE_BUILD: |
             make install-protoc-dependencies
             make install-go-proto-dependencies
             make install-go-ci-dependencies
-            make build-ui
 
       - uses: actions/upload-artifact@v2
         with:
@@ -222,6 +266,7 @@ jobs:
           make build-ui
       - name: Build
         run: |
+          python3 setup.py build_python_protos
           python3 setup.py sdist bdist_wheel
 
       - uses: actions/upload-artifact@v2
diff --git a/setup.py b/setup.py
@@ -355,11 +355,11 @@ class BuildCommand(build_py):
 
     def run(self):
         self.run_command("build_python_protos")
-        self.run_command("build_ext")
         if os.getenv("COMPILE_GO", "false").lower() == "true":
             _ensure_go_and_proto_toolchain()
             self.run_command("build_go_protos")
 
+        self.run_command("build_ext")
         build_py.run(self)
 
 
