Skip to content

Commit 9c11934

Browse files
author
Himanshu Singh
committed
fixing errors
Signed-off-by: Himanshu Singh <himanshu.singh@walmart.com>
1 parent 67ce1d7 commit 9c11934

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

sdk/python/feast/infra/offline_stores/bigquery.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -343,14 +343,19 @@ def get_historical_features(
343343
)
344344
entity_schema_keys = entity_schema.keys()
345345
all_entities = []
346-
fv_query_contexts_pre = None
347346
start_date = entity_df_event_timestamp_range[0]
348347
end_date = entity_df_event_timestamp_range[1]
348+
fv_query_contexts_pre = offline_utils.get_feature_view_query_context(
349+
feature_refs,
350+
feature_views,
351+
registry,
352+
project,
353+
entity_df_event_timestamp_range,
354+
)
349355

350356
@contextlib.contextmanager
351357
def query_generator() -> Iterator[str]:
352358
if non_entity_mode:
353-
assert fv_query_contexts_pre is not None
354359
_bq_create_entity_union_table(
355360
client=client,
356361
table_name=table_reference,
@@ -376,9 +381,8 @@ def query_generator() -> Iterator[str]:
376381
)
377382

378383
# Generate the BigQuery SQL query from the query context
379-
assert fv_query_contexts_pre is not None
380384
query = offline_utils.build_point_in_time_query(
381-
feature_view_query_contexts=fv_query_contexts_pre, # using pre created context
385+
feature_view_query_contexts=fv_query_contexts_pre,
382386
left_table_query_string=table_reference,
383387
entity_df_event_timestamp_col=event_timestamp_col,
384388
entity_df_columns=entity_schema_keys,
@@ -636,7 +640,7 @@ def _bq_create_entity_union_table(
636640
if col in ctx_entities_set:
637641
select_entities.append(f"`{col}`")
638642
else:
639-
select_entities.append(f"CAST(NULL AS STRING) AS `{col}`")
643+
select_entities.append(f"NULL AS `{col}`")
640644

641645
per_view_selects.append(
642646
f"SELECT DISTINCT {', '.join(select_entities)} "

0 commit comments

Comments
 (0)