fix: Assertion condition when value is 0 (#3401)

kysersozelee · km-zlatan-el · web-flow · commit 98a24a34c427 · 2022-12-20T07:58:26.000-08:00
* fix: Add assertion condition when value is 0

Signed-off-by: zlatan.el &lt;zlatan.el@kakaomobility.com&gt;

* chore: Add comment about zero value validation

Signed-off-by: zlatan.el &lt;zlatan.el@kakaomobility.com&gt;

* chore: Modifiy the comment

Signed-off-by: zlatan.el &lt;zlatan.el@kakaomobility.com&gt;

* chore: Add the comment

Signed-off-by: zlatan.el &lt;zlatan.el@kakaomobility.com&gt;

Signed-off-by: zlatan.el &lt;zlatan.el@kakaomobility.com&gt;
Co-authored-by: zlatan.el &lt;zlatan.el@kakaomobility.com&gt;
diff --git a/sdk/python/feast/type_map.py b/sdk/python/feast/type_map.py
@@ -402,7 +402,12 @@ def _python_value_to_proto_value(
             valid_scalar_types,
         ) = PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE[feast_value_type]
         if valid_scalar_types:
-            assert type(sample) in valid_scalar_types
+            if sample == 0 or sample == 0.0:
+                # Numpy convert 0 to int. However, in the feature view definition, the type of column may be a float.
+                # So, if value is 0, type validation must pass if scalar_types are either int or float.
+                assert type(sample) in [np.int64, int, np.float64, float]
+            else:
+                assert type(sample) in valid_scalar_types
         if feast_value_type == ValueType.BOOL:
             # ProtoValue does not support conversion of np.bool_ so we need to convert it to support np.bool_.
             return [
