fix(go): skip registry refresh when cache_ttl_seconds <= 0

samuelkim7 · ntkathole · commit 97ed40ca175e · 2026-05-22T17:27:22.000+05:30
Signed-off-by: samuelkim7 &lt;samuel.kim@goflink.com&gt;
diff --git a/go/internal/feast/registry/registry.go b/go/internal/feast/registry/registry.go
@@ -81,6 +81,10 @@ func (r *Registry) InitializeRegistry() error {
 }
 
 func (r *Registry) RefreshRegistryOnInterval() {
+	if r.cachedRegistryProtoTtl <= 0 {
+		log.Info().Msg("Registry cache TTL is non-positive; skipping periodic refresh")
+		return
+	}
 	ticker := time.NewTicker(r.cachedRegistryProtoTtl)
 	for ; true; <-ticker.C {
 		err := r.refresh()
diff --git a/go/internal/feast/registry/registry_test.go b/go/internal/feast/registry/registry_test.go
@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/aws/aws-sdk-go-v2/service/s3"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestCloudRegistryStores(t *testing.T) {
@@ -99,6 +100,24 @@ func TestCloudRegistryStores(t *testing.T) {
 	}
 }
 
+func TestRefreshRegistryOnIntervalNonPositiveTTL(t *testing.T) {
+	tests := []struct {
+		name string
+		ttl  time.Duration
+	}{
+		{name: "zero ttl", ttl: 0},
+		{name: "negative ttl", ttl: -1 * time.Second},
+	}
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			r := &Registry{cachedRegistryProtoTtl: test.ttl}
+			assert.NotPanics(t, func() {
+				r.RefreshRegistryOnInterval()
+			})
+		})
+	}
+}
+
 // MockS3Client is mock client for testing S3 registry store
 type MockS3Client struct {
 	GetObjectFn    func(ctx context.Context, params *s3.GetObjectInput, optFns ...func(*s3.Options)) (*s3.GetObjectOutput, error)
