Skip to content

Commit 96d3173

Browse files
author
Mansi Bhargava
committed
Add column for job_id in BQ
1 parent 2e1bc6c commit 96d3173

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

core/src/main/java/feast/core/storage/BigQueryStorageManager.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public class BigQueryStorageManager implements StorageManager {
4444
private static final String FIELD_ID = "id";
4545
private static final String FIELD_EVENT_TIMESTAMP = "event_timestamp";
4646
private static final String FIELD_CREATED_TIMESTAMP = "created_timestamp";
47+
private static final String FIELD_JOB_ID = "job_id";
4748

4849
private String id;
4950
private final BigQuery bigQuery;
@@ -103,6 +104,7 @@ public void registerNewFeature(FeatureSpec featureSpec) {
103104
createField(FIELD_ID, Enum.STRING, ""),
104105
createField(FIELD_EVENT_TIMESTAMP, Enum.TIMESTAMP, FIELD_EVENT_TIMESTAMP),
105106
createField(FIELD_CREATED_TIMESTAMP, Enum.TIMESTAMP, FIELD_CREATED_TIMESTAMP),
107+
createField(FIELD_JOB_ID, Enum.STRING, FIELD_JOB_ID),
106108
createFeatureField(featureSpec));
107109
TableDefinition tableDefinition =
108110
StandardTableDefinition.newBuilder()
@@ -137,7 +139,9 @@ public void registerNewFeature(FeatureSpec featureSpec) {
137139
f ->
138140
!f.equals(FIELD_ID)
139141
&& !f.equals(FIELD_CREATED_TIMESTAMP)
140-
&& !f.equals(FIELD_EVENT_TIMESTAMP))
142+
&& !f.equals(FIELD_EVENT_TIMESTAMP)
143+
&& !f.equals(FIELD_JOB_ID))
144+
141145
.collect(Collectors.toList()));
142146
AuditLogger.log(
143147
Resource.STORAGE,

core/src/test/java/feast/core/storage/BigQueryStorageManagerTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,17 @@ public void shouldCreateNewDatasetAndTableAndViewIfNotExist() throws Interrupted
115115
actualTable.getTableId().getTable(),
116116
equalTo(String.format("%s_%s", entityName, granularity.toString().toLowerCase())));
117117
List<Field> fields = actualTable.getDefinition().getSchema().getFields();
118-
assertThat(fields.size(), equalTo(4));
118+
assertThat(fields.size(), equalTo(5));
119119
Field idField = fields.get(0);
120120
assertThat(idField.getName(), equalTo("id"));
121121
Field etsField = fields.get(1);
122122
assertThat(etsField.getName(), equalTo("event_timestamp"));
123123
Field ctsField = fields.get(2);
124124
assertThat(ctsField.getName(), equalTo("created_timestamp"));
125-
Field field = fields.get(3);
125+
Field field = fields.get(4);
126126
assertThat(field.getDescription(), equalTo(description));
127+
Field jobIdField = fields.get(3);
128+
assertThat(jobIdField.getName(), equalTo("job_id"));
127129
assertThat(field.getType(), equalTo(LegacySQLTypeName.INTEGER));
128130
assertThat(field.getName(), equalTo(featureName));
129131

0 commit comments

Comments
 (0)