fix: Address additional Devin review feedback

franciscojavierarceo · claude · franciscojavierarceo · commit 903bda53eafb · 2026-03-17T08:55:00.000-04:00
- Set spec.project on snapshot protos in SqlRegistry before serializing, so version snapshots include the correct project field - Fix _check_versioned_read_support to check projection.version_tag instead of current_version_number, so explicitly version-qualified reads (@v0) are correctly rejected on non-SQLite stores Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/sdk/python/feast/infra/online_stores/online_store.py b/sdk/python/feast/infra/online_stores/online_store.py
@@ -244,9 +244,11 @@ def _check_versioned_read_support(self, grouped_refs):
         if isinstance(self, SqliteOnlineStore):
             return
         for table, _ in grouped_refs:
-            version = getattr(table, "current_version_number", None)
-            if version is not None and version > 0:
-                raise VersionedOnlineReadNotSupported(self.__class__.__name__, version)
+            version_tag = getattr(table.projection, "version_tag", None)
+            if version_tag is not None:
+                raise VersionedOnlineReadNotSupported(
+                    self.__class__.__name__, version_tag
+                )
 
     async def get_online_features_async(
         self,
diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py
@@ -729,7 +729,9 @@ def apply_feature_view(
 
             # Update current_version_number before saving snapshot
             feature_view.current_version_number = next_ver
-            snapshot_proto_bytes = feature_view.to_proto().SerializeToString()
+            snapshot_proto = feature_view.to_proto()
+            snapshot_proto.spec.project = project
+            snapshot_proto_bytes = snapshot_proto.SerializeToString()
 
             # Save new as next version (with correct current_version_number)
             self._save_version_snapshot(
@@ -755,7 +757,9 @@ def apply_feature_view(
         else:
             # New FV: save as v0
             feature_view.current_version_number = 0
-            snapshot_proto_bytes = feature_view.to_proto().SerializeToString()
+            snapshot_proto = feature_view.to_proto()
+            snapshot_proto.spec.project = project
+            snapshot_proto_bytes = snapshot_proto.SerializeToString()
             self._save_version_snapshot(
                 feature_view.name,
                 project,
