Skip to content

Commit 8bf8d3b

Browse files
author
zhilingc
committed
Add RedisKey
1 parent f8c14d9 commit 8bf8d3b

File tree

2 files changed

+39
-1
lines changed

2 files changed

+39
-1
lines changed

protos/feast/core/FeatureSet.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ message FeatureSetSpec {
3232
// FeatureSet version.
3333
int32 version = 2;
3434

35-
// List of entities contained within this featureSet. Describes whether a feature is also a key.
35+
// List of entities contained within this featureSet.
3636
// This allows the feature to be used during joins between feature sets.
3737
// If the featureSet is ingested into a store that supports keys, this value
3838
// will be made a key.

protos/feast/storage/Redis.proto

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
* Copyright 2019 The Feast Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
syntax = "proto3";
18+
import "google/protobuf/timestamp.proto";
19+
20+
import "feast/types/Field.proto";
21+
22+
package feast.storage;
23+
24+
option java_outer_classname = "RedisProto";
25+
option java_package = "feast.storage";
26+
option go_package = "github.com/gojek/feast/protos/generated/go/feast/storage";
27+
28+
message RedisKey {
29+
// Field number 1 is reserved for a future distributing hash if needed
30+
// (for when redis is clustered).
31+
32+
// FeatureSet this row belongs to, this is defined as featureSetName:version.
33+
string featureSet = 2;
34+
35+
// List of fields containing entity names and their respective values
36+
// contained within this feature row.
37+
repeated feast.types.Field entities = 3;
38+
}

0 commit comments

Comments
 (0)