chore: Remove outdated error message (#3026)

felixwang9817 · web-flow · commit 8bc53bd4c83f · 2022-08-05T17:16:42.000-07:00
Remove outdated 0.24 error message

Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;
diff --git a/sdk/python/feast/errors.py b/sdk/python/feast/errors.py
@@ -19,6 +19,13 @@ def __init__(self):
         )
 
 
+class DataSourceRepeatNamesException(Exception):
+    def __init__(self, ds_name: str):
+        super().__init__(
+            f"Multiple data sources share the same case-insensitive name {ds_name}."
+        )
+
+
 class FeastObjectNotFoundException(Exception):
     pass
 
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -49,6 +49,7 @@
 from feast.dqm.errors import ValidationFailed
 from feast.entity import Entity
 from feast.errors import (
+    DataSourceRepeatNamesException,
     EntityNotFoundException,
     FeatureNameCollisionError,
     FeatureViewNotFoundException,
@@ -2551,19 +2552,12 @@ def _validate_feature_views(feature_views: List[BaseFeatureView]):
 
 
 def _validate_data_sources(data_sources: List[DataSource]):
-    """Verify data sources have case-insensitively unique names"""
+    """Verify data sources have case-insensitively unique names."""
     ds_names = set()
     for ds in data_sources:
         case_insensitive_ds_name = ds.name.lower()
         if case_insensitive_ds_name in ds_names:
-            if case_insensitive_ds_name.strip():
-                warnings.warn(
-                    f"More than one data source with name {case_insensitive_ds_name} found. "
-                    f"Please ensure that all data source names are case-insensitively unique. "
-                    f"It may be necessary to ignore certain files in your feature repository by using a .feastignore "
-                    f"file. Starting in Feast 0.24, unique names (perhaps inferred from the table name) will be "
-                    f"required in data sources to encourage data source discovery"
-                )
+            raise DataSourceRepeatNamesException(case_insensitive_ds_name)
         else:
             ds_names.add(case_insensitive_ds_name)
 
diff --git a/sdk/python/tests/unit/cli/test_cli_apply_duplicates.py b/sdk/python/tests/unit/cli/test_cli_apply_duplicates.py
@@ -15,7 +15,7 @@ def test_cli_apply_duplicated_featureview_names() -> None:
 def test_cli_apply_duplicate_data_source_names() -> None:
     run_simple_apply_test(
         example_repo_file_name="example_repo_duplicate_data_source_names.py",
-        expected_error=b"Please ensure that all data source names are case-insensitively unique",
+        expected_error=b"Multiple data sources share the same case-insensitive name",
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ def test_cli_apply_duplicated_featureview_names() -> None:`
`15`	`15`	`def test_cli_apply_duplicate_data_source_names() -> None:`
`16`	`16`	`run_simple_apply_test(`
`17`	`17`	`example_repo_file_name="example_repo_duplicate_data_source_names.py",`
`18`		`- expected_error=b"Please ensure that all data source names are case-insensitively unique",`
	`18`	`+ expected_error=b"Multiple data sources share the same case-insensitive name",`
`19`	`19`	`)`
`20`	`20`
`21`	`21`