fix: Return 422 on bad push source name (#3214)

robhowley · Rob Howley · adchia · commit 8abbcd9960bb · 2022-09-30T16:11:40.000-05:00
* return 422 on bad push source name

Signed-off-by: Rob Howley &lt;rhowley@seatgeek.com&gt;

* fix: cant send empty df

Signed-off-by: Rob Howley &lt;rhowley@seatgeek.com&gt;

* return 422 on bad push source name

Signed-off-by: Rob Howley &lt;rhowley@seatgeek.com&gt;

* fix: cant send empty df

Signed-off-by: Rob Howley &lt;rhowley@seatgeek.com&gt;

* fix: json.dumps the body in the post 🤦

Signed-off-by: Rob Howley &lt;rhowley@seatgeek.com&gt;

Signed-off-by: Rob Howley &lt;rhowley@seatgeek.com&gt;
Co-authored-by: Rob Howley &lt;rhowley@seatgeek.com&gt;
diff --git a/sdk/python/feast/errors.py b/sdk/python/feast/errors.py
@@ -398,3 +398,8 @@ def __init__(self):
         super().__init__(
             "The entity dataframe specified does not have the timestamp field as a datetime."
         )
+
+
+class PushSourceNotFoundException(Exception):
+    def __init__(self, push_source_name: str):
+        super().__init__(f"Unable to find push source '{push_source_name}'.")
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -13,6 +13,7 @@
 import feast
 from feast import proto_json
 from feast.data_source import PushMode
+from feast.errors import PushSourceNotFoundException
 from feast.protos.feast.serving.ServingService_pb2 import GetOnlineFeaturesRequest
 
 
@@ -98,6 +99,11 @@ def push(body=Depends(get_body)):
                 allow_registry_cache=request.allow_registry_cache,
                 to=to,
             )
+        except PushSourceNotFoundException as e:
+            # Print the original exception on the server side
+            logger.exception(traceback.format_exc())
+            # Raise HTTPException to return the error message to the client
+            raise HTTPException(status_code=422, detail=str(e))
         except Exception as e:
             # Print the original exception on the server side
             logger.exception(traceback.format_exc())
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -59,6 +59,7 @@
     EntityNotFoundException,
     FeatureNameCollisionError,
     FeatureViewNotFoundException,
+    PushSourceNotFoundException,
     RequestDataNotFoundInEntityDfException,
     RequestDataNotFoundInEntityRowsException,
 )
@@ -1445,6 +1446,9 @@ def push(
             )
         }
 
+        if not fvs_with_push_sources:
+            raise PushSourceNotFoundException(push_source_name)
+
         for fv in fvs_with_push_sources:
             if to == PushMode.ONLINE or to == PushMode.ONLINE_AND_OFFLINE:
                 self.write_to_online_store(
diff --git a/sdk/python/tests/integration/e2e/test_python_feature_server.py b/sdk/python/tests/integration/e2e/test_python_feature_server.py
@@ -84,6 +84,29 @@ def test_push(python_fs_client):
     ) == [initial_temp * 100]
 
 
+@pytest.mark.integration
+@pytest.mark.universal_online_stores
+def test_push_source_does_not_exist(python_fs_client):
+    initial_temp = _get_temperatures_from_feature_server(
+        python_fs_client, location_ids=[1]
+    )[0]
+    response = python_fs_client.post(
+        "/push",
+        data=json.dumps(
+            {
+                "push_source_name": "push_source_does_not_exist",
+                "df": {
+                    "location_id": [1],
+                    "temperature": [initial_temp * 100],
+                    "event_timestamp": [str(datetime.utcnow())],
+                    "created": [str(datetime.utcnow())],
+                },
+            }
+        ),
+    )
+    assert response.status_code == 422
+
+
 def _get_temperatures_from_feature_server(client, location_ids: List[int]):
     get_request_data = {
         "features": ["pushable_location_stats:temperature"],

Original file line number	Diff line number	Diff line change
`@@ -398,3 +398,8 @@ def __init__(self):`
`398`	`398`	`super().__init__(`
`399`	`399`	`"The entity dataframe specified does not have the timestamp field as a datetime."`
`400`	`400`	`)`
	`401`	`+`
	`402`	`+`
	`403`	`+class PushSourceNotFoundException(Exception):`
	`404`	`+ def __init__(self, push_source_name: str):`
	`405`	`+ super().__init__(f"Unable to find push source '{push_source_name}'.")`
Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@`
`59`	`59`	`EntityNotFoundException,`
`60`	`60`	`FeatureNameCollisionError,`
`61`	`61`	`FeatureViewNotFoundException,`
	`62`	`+ PushSourceNotFoundException,`
`62`	`63`	`RequestDataNotFoundInEntityDfException,`
`63`	`64`	`RequestDataNotFoundInEntityRowsException,`
`64`	`65`	`)`
`@@ -1445,6 +1446,9 @@ def push(`
`1445`	`1446`	`)`
`1446`	`1447`	`}`
`1447`	`1448`
	`1449`	`+ if not fvs_with_push_sources:`
	`1450`	`+ raise PushSourceNotFoundException(push_source_name)`
	`1451`	`+`
`1448`	`1452`	`for fv in fvs_with_push_sources:`
`1449`	`1453`	`if to == PushMode.ONLINE or to == PushMode.ONLINE_AND_OFFLINE:`
`1450`	`1454`	`self.write_to_online_store(`