fix: Remove unused param, nil deref in test, and update secrets baseline

aniketpalu · aniketpalu · commit 8aae62ae5145 · 2026-04-07T15:32:29.000+05:30
Signed-off-by: Aniket Paluskar &lt;apaluska@redhat.com&gt;
diff --git a/.secrets.baseline b/.secrets.baseline
@@ -934,7 +934,7 @@
         "filename": "infra/feast-operator/api/v1/featurestore_types.go",
         "hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
         "is_verified": false,
-        "line_number": 729
+        "line_number": 756
       }
     ],
     "infra/feast-operator/api/v1/zz_generated.deepcopy.go": [
@@ -950,14 +950,14 @@
         "filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
         "hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
         "is_verified": false,
-        "line_number": 1254
+        "line_number": 747
       },
       {
         "type": "Secret Keyword",
         "filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
         "hashed_secret": "c2028031c154bbe86fd69bef740855c74b927dcf",
         "is_verified": false,
-        "line_number": 1259
+        "line_number": 1293
       }
     ],
     "infra/feast-operator/api/v1alpha1/featurestore_types.go": [
@@ -1140,14 +1140,14 @@
         "filename": "infra/feast-operator/internal/controller/services/repo_config.go",
         "hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
         "is_verified": false,
-        "line_number": 109
+        "line_number": 114
       },
       {
         "type": "Secret Keyword",
         "filename": "infra/feast-operator/internal/controller/services/repo_config.go",
         "hashed_secret": "e2fb052132fd6a07a56af2013e0b62a1f510572c",
         "is_verified": false,
-        "line_number": 148
+        "line_number": 204
       }
     ],
     "infra/feast-operator/internal/controller/services/services.go": [
@@ -1539,5 +1539,5 @@
       }
     ]
   },
-  "generated_at": "2026-03-18T13:51:43Z"
+  "generated_at": "2026-04-07T09:25:31Z"
 }
diff --git a/infra/feast-operator/internal/controller/services/repo_config.go b/infra/feast-operator/internal/controller/services/repo_config.go
@@ -354,7 +354,7 @@ func getClientRepoConfig(
 	feast *FeastServices) (RepoConfig, error) {
 	status := featureStore.Status
 	appliedServices := status.Applied.Services
-	clientRepoConfig, err := getRepoConfig(featureStore, secretExtractionFunc)
+	clientRepoConfig, err := getRepoConfig(featureStore)
 	if err != nil {
 		return clientRepoConfig, err
 	}
@@ -398,9 +398,7 @@ func getClientRepoConfig(
 	return clientRepoConfig, nil
 }
 
-func getRepoConfig(
-	featureStore *feastdevv1.FeatureStore,
-	secretExtractionFunc func(storeType string, secretRef string, secretKeyName string) (map[string]interface{}, error)) (RepoConfig, error) {
+func getRepoConfig(featureStore *feastdevv1.FeatureStore) (RepoConfig, error) {
 	status := featureStore.Status
 	repoConfig := initRepoConfig(status.Applied.FeastProject)
 	if status.Applied.AuthzConfig != nil {
diff --git a/infra/feast-operator/internal/controller/services/repo_config_test.go b/infra/feast-operator/internal/controller/services/repo_config_test.go
@@ -370,7 +370,6 @@ var _ = Describe("Repo Config", func() {
 		Expect(err).NotTo(HaveOccurred())
 		_, err = getClientRepoConfig(featureStore, secretExtractionFunc, nil)
 		Expect(err).NotTo(HaveOccurred())
-		Expect(err.Error()).To(ContainSubstring("missing OIDC secret"))
 	})
 })
 
