Skip to content

Commit 886a69d

Browse files
authored
chore: Added make command to build locally built Feast UI package (#5356)
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
1 parent a114aae commit 886a69d

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed

Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -644,6 +644,11 @@ build-helm-docs:
644644
build-ui:
645645
cd $(ROOT_DIR)/sdk/python/feast/ui && yarn upgrade @feast-dev/feast-ui --latest && yarn install && npm run build --omit=dev
646646

647+
build-ui-local:
648+
cd $(ROOT_DIR)/ui && yarn install && npm run build --omit=dev
649+
rm -rf $(ROOT_DIR)/sdk/python/feast/ui/build
650+
cp -r $(ROOT_DIR)/ui/build $(ROOT_DIR)/sdk/python/feast/ui/
651+
647652
format-ui:
648653
cd $(ROOT_DIR)/ui && NPM_TOKEN= yarn install && NPM_TOKEN= yarn format
649654

docs/project/development-guide.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,20 @@ Note that this means if you are midway through working through a PR and rebase,
135135
- activate the venv: `source venv/bin/activate`
136136
- Install dependencies `make install-python-dependencies-dev`
137137

138-
### building the UI
138+
### Building the UI
139+
To build the UI from the latest released NPM package (hosted under @feast-dev/feast-ui):
140+
139141
```sh
140142
make build-ui
141143
```
142144

145+
If you want to test backend and frontend together using 'feast ui' command and with a locally built Feast UI package, you can build using:
146+
147+
```sh
148+
make build-ui-local
149+
```
150+
Use this when you are making changes to the React UI code and want to see them live via the backend.
151+
143152
### Recompiling python lock files
144153
Recompile python lock files. This only needs to be run when you make changes to requirements or simply want to update python lock files to reflect latest versions.
145154

sdk/python/feast/ui/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,15 @@ The `feast ui` command will generate the necessary `projects-list.json` file and
2626

2727
## Dev
2828
To test with a locally built Feast UI package, do:
29+
30+
```bash
31+
make build-ui-local
32+
feast ui
33+
```
34+
35+
OR
36+
37+
You can also do:
2938
1. `yarn link` in ui/
3039
2. `yarn install` in ui/
3140
3. `yarn link` in ui/node_modules/react

0 commit comments

Comments
 (0)