CR

achals · achals · commit 81d6d41d38d2 · 2021-06-28T11:38:09.000-07:00
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/protos/feast/core/FeatureView.proto b/protos/feast/core/FeatureView.proto
@@ -60,6 +60,7 @@ message FeatureViewSpec {
 
     // Batch/Offline DataSource where this view can retrieve offline feature data.
     DataSource batch_source = 7;
+    // Streaming DataSource from where this view can consume "online" feature data.
     DataSource stream_source = 9;
 
     // Whether these features should be served online or not
diff --git a/sdk/python/feast/data_source.py b/sdk/python/feast/data_source.py
@@ -869,6 +869,9 @@ def __init__(
         )
 
     def __eq__(self, other):
+        if other is None:
+            return False
+
         if not isinstance(other, KinesisSource):
             raise TypeError(
                 "Comparisons should only involve KinesisSource class objects."
diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py
@@ -228,7 +228,7 @@ def from_proto(cls, feature_view_proto: FeatureViewProto):
             batch_source=_input,
             stream_source=(
                 feature_view_proto.spec.stream_source
-                if feature_view_proto.spec.stream_source is None
+                if feature_view_proto.spec.stream_source is not None
                 else None
             ),
         )

Original file line number	Diff line number	Diff line change
`@@ -869,6 +869,9 @@ def __init__(`
`869`	`869`	`)`
`870`	`870`
`871`	`871`	`def __eq__(self, other):`
	`872`	`+ if other is None:`
	`873`	`+ return False`
	`874`	`+`
`872`	`875`	`if not isinstance(other, KinesisSource):`
`873`	`876`	`raise TypeError(`
`874`	`877`	`"Comparisons should only involve KinesisSource class objects."`
Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ def from_proto(cls, feature_view_proto: FeatureViewProto):`
`228`	`228`	`batch_source=_input,`
`229`	`229`	`stream_source=(`
`230`	`230`	`feature_view_proto.spec.stream_source`
`231`		`- if feature_view_proto.spec.stream_source is None`
	`231`	`+ if feature_view_proto.spec.stream_source is not None`
`232`	`232`	`else None`
`233`	`233`	`),`
`234`	`234`	`)`