fx

adchia · adchia · commit 813c420a6119 · 2022-05-14T14:29:35.000-04:00
Signed-off-by: Danny Chiao &lt;danny@tecton.ai&gt;
diff --git a/sdk/python/feast/ui/README.md b/sdk/python/feast/ui/README.md
@@ -1,6 +1,6 @@
 # Example Feast UI App
 
-This is an example React App that imports the Feast UI module and relies on a "/projects-list" endpoint to get projects.
+This is an example React App that imports the Feast UI module. 
 
 See the module import in `src/index.js`. The main change this implements on top of a vanilla create-react-app is adding:
 
@@ -11,23 +11,15 @@ import "@feast-dev/feast-ui/dist/feast-ui.css";
 
 ReactDOM.render(
   <React.StrictMode>
-    <FeastUI
-      feastUIConfigs={{
-        projectListPromise: fetch("http://0.0.0.0:8888/projects-list", {
-          headers: {
-            "Content-Type": "application/json",
-          },
-        }).then((res) => {
-          return res.json();
-        })
-      }}
-    />
+    <FeastUI />
   </React.StrictMode>,
   document.getElementById("root")
 );
 ```
 
-It is used by the `feast ui` command to scaffold a local UI server. The feast python package bundles in resources produced from `npm run build --omit=dev
+It is used by the `feast ui` command to scaffold a local UI server. The feast python package bundles in resources produced from `npm run build --omit=dev.` 
+
+The `feast ui` command will generate the necessary `projects-list.json` file and initialize it for the UI to read.
 
 
 **Note**: yarn start will not work on this because of the above dependency.
diff --git a/sdk/python/feast/ui_server.py b/sdk/python/feast/ui_server.py
@@ -2,11 +2,11 @@
 import threading
 from typing import Callable, Optional
 
-from importlib_resources import files, as_file
 import uvicorn
 from fastapi import FastAPI, Response
 from fastapi.middleware.cors import CORSMiddleware
 from fastapi.staticfiles import StaticFiles
+from importlib_resources import as_file, files
 
 import feast
 
@@ -19,8 +19,6 @@ def get_app(
     host: str,
     port: int,
 ):
-    ui_dir = files(__package__).joinpath("ui/build/")
-
     app = FastAPI()
 
     app.add_middleware(
@@ -55,9 +53,9 @@ def shutdown_event():
 
     async_refresh()
 
+    ui_dir = files(__package__).joinpath("ui/build/")
     # Initialize with the projects-list.json file
-    try:
-        f = ui_dir.joinpath("projects-list.json").open(mode="w")
+    with ui_dir.joinpath("projects-list.json").open(mode="w") as f:
         projects_dict = {
             "projects": [
                 {
@@ -69,12 +67,6 @@ def shutdown_event():
             ]
         }
         f.write(json.dumps(projects_dict))
-    except Exception as e:
-        raise RuntimeError(
-            "Failed to initialize projects-list.json with registry path"
-        ) from e
-    finally:
-        f.close()
 
     @app.get("/registry")
     def read_registry():
