Skip to content

Commit 80685c7

Browse files
davidheryantodavidheryanto
committed
Update Feast Helm chart
- Deployment: more configuration for liveness and readiness probes, fix usage of service account values - Service: allow users to provide custom annotations; default to ClusterIP type to prevent accidental exposing of services to external
1 parent 89783f6 commit 80685c7

13 files changed

Lines changed: 62 additions & 53 deletions

‎charts/dist/feast-0.1.0.tgz‎

-29.9 KB
Binary file not shown.

‎charts/dist/index.yaml‎

Lines changed: 0 additions & 13 deletions
This file was deleted.

‎charts/feast/charts/postgresql-0.19.0.tgz‎

-8.4 KB
Binary file not shown.

‎charts/feast/charts/postgresql-3.17.0.tgz‎

18.7 KB
Binary file not shown.

‎charts/feast/charts/redis-6.0.0.tgz‎

-19.2 KB
Binary file not shown.

‎charts/feast/charts/redis-6.4.4.tgz‎

19.7 KB
Binary file not shown.

‎charts/feast/requirements.lock‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
dependencies:
22
- name: postgresql
33
repository: https://kubernetes-charts.storage.googleapis.com
4-
version: 0.19.0
4+
version: 3.17.0
55
- name: redis
66
repository: https://kubernetes-charts.storage.googleapis.com
7-
version: 6.0.0
8-
digest: sha256:cb4801425432b544a54462d657daf5ffb8bc18eb5f25b39ef5560a66ae4975eb
9-
generated: 2019-02-07T10:54:57.715495851+08:00
7+
version: 6.4.4
8+
digest: sha256:e1fb31a7beda17b642a0e1a5369bb8184a7206573e48f07b1bb4ebe35ba9bead
9+
generated: 2019-04-24T16:00:44.597053887+08:00

‎charts/feast/requirements.yaml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
dependencies:
2-
- name: postgresql
3-
version: ^0.19.0
4-
repository: "@stable"
5-
condition: postgres.provision
6-
- name: redis
7-
version: ^6.0.0
8-
repository: "@stable"
9-
condition: redis.provision
2+
- name: postgresql
3+
version: 3.17.0
4+
repository: "@stable"
5+
condition: postgres.provision
6+
- name: redis
7+
version: 6.4.4
8+
repository: "@stable"
9+
condition: redis.provision

‎charts/feast/templates/core-deploy.yaml‎

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,21 @@ spec:
3737
path: /ping
3838
port: {{ .Values.core.service.http.targetPort }}
3939
scheme: HTTP
40-
initialDelaySeconds: 120
40+
initialDelaySeconds: {{ .Values.core.livenessProbe.initialDelaySeconds }}
4141
periodSeconds: 10
4242
successThreshold: 1
4343
timeoutSeconds: 5
44+
failureThreshold: {{ .Values.core.livenessProbe.failureThreshold }}
4445
readinessProbe:
4546
httpGet:
4647
path: /healthz
4748
port: {{ .Values.core.service.http.targetPort }}
4849
scheme: HTTP
49-
initialDelaySeconds: 120
50-
periodSeconds: 10
50+
initialDelaySeconds: {{ .Values.core.readinessProbe.initialDelaySeconds }}
51+
periodSeconds: 5
5152
successThreshold: 1
52-
timeoutSeconds: 5
53+
timeoutSeconds: 3
54+
failureThreshold: {{ .Values.core.readinessProbe.failureThreshold }}
5355
resources:
5456
requests:
5557
cpu: {{ .Values.core.resources.requests.cpu }}
@@ -59,9 +61,9 @@ spec:
5961
memory: {{ .Values.core.resources.limits.memory }}
6062
{{- if .Values.serviceAccount }}
6163
volumeMounts:
62-
- mountPath: "/etc/gcloud/service-accounts"
63-
name: "{{ .Values.serviceAccount.name }}"
64-
readOnly: false
64+
- name: "{{ .Values.serviceAccount.name }}"
65+
mountPath: "/etc/gcloud/service-accounts"
66+
readOnly: true
6567
{{- end }}
6668
env:
6769
- name: GRPC_PORT
@@ -123,9 +125,9 @@ spec:
123125
{{- end }}
124126
{{- if .Values.serviceAccount }}
125127
- name: GOOGLE_APPLICATION_CREDENTIALS
126-
value: /etc/gcloud/service-accounts/key.json
128+
value: /etc/gcloud/service-accounts/{{ .Values.serviceAccount.key }}
127129
volumes:
128130
- name: "{{ .Values.serviceAccount.name }}"
129131
secret:
130-
secretName: "{{ .Values.serviceAccount.key }}"
132+
secretName: "{{ .Values.serviceAccount.name }}"
131133
{{- end }}

‎charts/feast/templates/core-service.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ metadata:
88
chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
99
release: {{ .Release.Name }}
1010
heritage: {{ .Release.Service }}
11+
{{- with .Values.core.service.annotations }}
1112
annotations:
12-
cloud.google.com/load-balancer-type: "Internal"
13+
{{ toYaml . | indent 4 }}
14+
{{- end }}
1315
spec:
14-
type: LoadBalancer
16+
type: {{ .Values.core.service.type }}
1517
{{- if .Values.core.service.extIPAdr }}
1618
loadBalancerIP: {{ .Values.core.service.extIPAdr }}
1719
{{- end }}

0 commit comments

Comments
 (0)