fix: Remove PySpark dependency from Snowflake Offline Store (#3388)

beauchbum · adchia · web-flow · commit 7b160c746858 · 2022-12-14T14:33:22.000-08:00
* fix: Wrap pyspark import in try except for snowflake offline store

Signed-off-by: Ryan Beauchamp &lt;ryan.beauchamp@ezcater.com&gt;

* fix: Capture exception

Signed-off-by: Ryan Beauchamp &lt;ryan.beauchamp@ezcater.com&gt;

* fix: update jinja template

Signed-off-by: Ryan Beauchamp &lt;ryan.beauchamp@ezcater.com&gt;

* lint

Signed-off-by: Danny Chiao &lt;danny@tecton.ai&gt;

Signed-off-by: Ryan Beauchamp &lt;ryan.beauchamp@ezcater.com&gt;
Signed-off-by: Danny Chiao &lt;danny@tecton.ai&gt;
Co-authored-by: Danny Chiao &lt;danny@tecton.ai&gt;
diff --git a/infra/templates/README.md.jinja2 b/infra/templates/README.md.jinja2
@@ -42,7 +42,7 @@ pip install feast
 ### 2. Create a feature repository
 ```commandline
 feast init my_feature_repo
-cd my_feature_repo
+cd my_feature_repo/feature_repo
 ```
 
 ### 3. Register your feature definitions and set up your feature store
diff --git a/sdk/python/feast/infra/offline_stores/snowflake.py b/sdk/python/feast/infra/offline_stores/snowflake.py
@@ -23,7 +23,6 @@
 import pyarrow
 from pydantic import Field, StrictStr
 from pydantic.typing import Literal
-from pyspark.sql import DataFrame, SparkSession
 from pytz import utc
 
 from feast import OnDemandFeatureView
@@ -64,6 +63,13 @@
 
     raise FeastExtrasDependencyImportError("snowflake", str(e))
 
+try:
+    from pyspark.sql import DataFrame, SparkSession
+except ImportError as e:
+    from feast.errors import FeastExtrasDependencyImportError
+
+    raise FeastExtrasDependencyImportError("spark", str(e))
+
 warnings.filterwarnings("ignore", category=DeprecationWarning)
 
 
