removing commenting and unnecessary code

franciscojavierarceo · franciscojavierarceo · commit 79cb8e1a10cf · 2025-03-22T20:41:04.000-04:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/infra/online_stores/sqlite.py b/sdk/python/feast/infra/online_stores/sqlite.py
@@ -176,14 +176,6 @@ def online_write_batch(
                             )  # type: ignore
                         else:
                             val_bin = feast_value_type_to_python_type(val)
-                        # print(
-                        #     f"entity_key_bin = {entity_key_bin} (type: {type(entity_key_bin)})\n"
-                        #     f"feature_name = {feature_name} (type: {type(feature_name)})\n"
-                        #     f"value = {val.SerializeToString()} (type: {type(val.SerializeToString())})\n"
-                        #     f"val_bin = {val_bin} (type: {type(val_bin)})\n"
-                        #     f"timestamp = {timestamp} (type: {type(timestamp)})\n"
-                        #     f"created_ts = {created_ts} (type: {type(created_ts)})\n"
-                        # )
                         conn.execute(
                             f"""
                             INSERT INTO {table_name} (entity_key, feature_name, value, vector_value, event_ts, created_ts)
@@ -489,7 +481,6 @@ def retrieve_online_documents_v2(
             raise ValueError("vector_len is not configured in the online store config")
 
         table_name = _table_id(config.project, table)
-        # Currently this is the problem
         vector_field = _get_vector_field(table)
 
         if online_store.vector_enabled:
diff --git a/sdk/python/tests/unit/online_store/test_online_retrieval.py b/sdk/python/tests/unit/online_store/test_online_retrieval.py
@@ -855,10 +855,10 @@ def test_sqlite_hybrid_search() -> None:
     res_df["title"].tolist() == ["Guardians of the Galaxy", "Sing", "Suicide Squad"]
 
 
-# @pytest.mark.skipif(
-#     sys.version_info[0:2] != (3, 10),
-#     reason="Only works on Python 3.10",
-# )
+@pytest.mark.skipif(
+    sys.version_info[0:2] != (3, 10),
+    reason="Only works on Python 3.10",
+)
 def test_sqlite_get_online_documents_v2() -> None:
     """Test retrieving documents using v2 method with vector similarity search."""
     n = 10
