Skip to content

Commit 78ff90f

Browse files
committed
improve comment
1 parent 408036f commit 78ff90f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sdk/python/feast/feature_store.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1236,7 +1236,8 @@ def get_historical_features(
12361236

12371237
# Deliberately disable writing to online store for ODFVs during historical retrieval
12381238
# since it's not applicable in this context.
1239-
# This technically does not change the output
1239+
# This does not change the output, since it forces to recompute ODFVs on historical retrieval
1240+
# but that is fine, since ODFVs precompute does not to historical retrieval, only online retrieval
12401241
for odfv in all_on_demand_feature_views:
12411242
odfv.write_to_online_store = False
12421243

0 commit comments

Comments
 (0)