Create scheduledExecutorService as field instead of local variable to avoid getting GC-ed (#189)

pradithya aria · feast-ci-bot · commit 78e65bb6ec22 · 2019-05-04T12:46:29.000+08:00
diff --git a/serving/src/main/java/feast/serving/config/ServingApiConfiguration.java b/serving/src/main/java/feast/serving/config/ServingApiConfiguration.java
@@ -47,6 +47,8 @@
 public class ServingApiConfiguration implements WebMvcConfigurer {
 
   @Autowired private ProtobufJsonFormatHttpMessageConverter protobufConverter;
+  private ScheduledExecutorService scheduledExecutorService =
+      Executors.newSingleThreadScheduledExecutor();
 
   @Bean
   public AppConfig getAppConfig(
@@ -67,14 +69,12 @@ public SpecStorage getCoreServiceSpecStorage(
       @Value("${feast.core.host}") String coreServiceHost,
       @Value("${feast.core.grpc.port}") String coreServicePort,
       @Value("${feast.cacheDurationMinute}") int cacheDurationMinute) {
-    ScheduledExecutorService scheduledExecutorService =
-        Executors.newSingleThreadScheduledExecutor();
     final CachedSpecStorage cachedSpecStorage =
         new CachedSpecStorage(new CoreService(coreServiceHost, Integer.parseInt(coreServicePort)));
 
     // reload all specs including new ones periodically
     scheduledExecutorService.schedule(
-        () -> cachedSpecStorage.populateCache(), cacheDurationMinute, TimeUnit.MINUTES);
+        cachedSpecStorage::populateCache, cacheDurationMinute, TimeUnit.MINUTES);
 
     // load all specs during start up
     try {
