updated tests

franciscojavierarceo · franciscojavierarceo · commit 784501fc3f1e · 2025-09-23T10:49:39.000+01:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/docs/reference/feature-servers/python-feature-server.md b/docs/reference/feature-servers/python-feature-server.md
@@ -200,6 +200,52 @@ requests.post(
     data=json.dumps(push_data))
 ```
 
+### Materializing features
+
+The Python feature server also exposes an endpoint for materializing features from the offline store to the online store.
+
+**Standard materialization with timestamps:**
+```bash
+curl -X POST "http://localhost:6566/materialize" -d '{
+    "start_ts": "2021-01-01T00:00:00",
+    "end_ts": "2021-01-02T00:00:00",
+    "feature_views": ["driver_hourly_stats"]
+}' | jq
+```
+
+**Materialize all data without event timestamps:**
+```bash
+curl -X POST "http://localhost:6566/materialize" -d '{
+    "feature_views": ["driver_hourly_stats"],
+    "disable_event_timestamp": true
+}' | jq
+```
+
+When `disable_event_timestamp` is set to `true`, the `start_ts` and `end_ts` parameters are not required, and all available data is materialized using the current datetime as the event timestamp. This is useful when your source data lacks proper event timestamp columns.
+
+Or from Python:
+```python
+import json
+import requests
+
+# Standard materialization
+materialize_data = {
+    "start_ts": "2021-01-01T00:00:00",
+    "end_ts": "2021-01-02T00:00:00",
+    "feature_views": ["driver_hourly_stats"]
+}
+
+# Materialize without event timestamps
+materialize_data_no_timestamps = {
+    "feature_views": ["driver_hourly_stats"],
+    "disable_event_timestamp": True
+}
+
+requests.post(
+    "http://localhost:6566/materialize",
+    data=json.dumps(materialize_data))
+```
+
 ## Starting the feature server in TLS(SSL) mode
 
 Enabling TLS mode ensures that data between the Feast client and server is transmitted securely. For an ideal production environment, it is recommended to start the feature server in TLS mode.
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -74,8 +74,8 @@ class PushFeaturesRequest(BaseModel):
 
 
 class MaterializeRequest(BaseModel):
-    start_ts: str
-    end_ts: str
+    start_ts: Optional[str] = None
+    end_ts: Optional[str] = None
     feature_views: Optional[List[str]] = None
     disable_event_timestamp: bool = False
 
@@ -441,6 +441,8 @@ def materialize(request: MaterializeRequest) -> None:
             start_date = datetime(1970, 1, 1)  # Beginning of time to capture all historical data
             end_date = now
         else:
+            if not request.start_ts or not request.end_ts:
+                raise ValueError("start_ts and end_ts are required when disable_event_timestamp is False")
             start_date = utils.make_tzaware(parser.parse(request.start_ts))
             end_date = utils.make_tzaware(parser.parse(request.end_ts))
 
diff --git a/sdk/python/tests/unit/cli/test_cli.py b/sdk/python/tests/unit/cli/test_cli.py
@@ -190,3 +190,31 @@ def test_cli_configuration():
         assertpy.assert_that(output).contains(b"path: data/online_store.db")
         assertpy.assert_that(output).contains(b"type: file")
         assertpy.assert_that(output).contains(b"entity_key_serialization_version: 3")
+
+
+def test_cli_materialize_disable_event_timestamp():
+    """
+    Unit test for the 'feast materialize --disable-event-timestamp' command
+    """
+    runner = CliRunner()
+
+    with setup_third_party_provider_repo("local") as repo_path:
+        # Test that --disable-event-timestamp flag works without timestamps
+        return_code, output = runner.run_with_output(
+            ["materialize", "--disable-event-timestamp"], cwd=repo_path
+        )
+        # Should succeed (though may not have data to materialize)
+        assertpy.assert_that(return_code).is_equal_to(0)
+
+        # Test that providing timestamps with --disable-event-timestamp fails
+        return_code, output = runner.run_with_output(
+            ["materialize", "--disable-event-timestamp", "2021-01-01T00:00:00", "2021-01-02T00:00:00"],
+            cwd=repo_path
+        )
+        assertpy.assert_that(return_code).is_equal_to(2)  # Click usage error
+        assertpy.assert_that(output).contains(b"Cannot specify START_TS or END_TS when --disable-event-timestamp is used")
+
+        # Test that missing timestamps without flag fails
+        return_code, output = runner.run_with_output(["materialize"], cwd=repo_path)
+        assertpy.assert_that(return_code).is_equal_to(2)  # Click usage error
+        assertpy.assert_that(output).contains(b"START_TS and END_TS are required unless --disable-event-timestamp is used")
diff --git a/sdk/python/tests/unit/test_feature_server.py b/sdk/python/tests/unit/test_feature_server.py
